New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: OverrideTester basePath (fixes #12032) #12205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Can we publish a patch release? This is really awesome! |
This will be released in the next scheduled release: https://github.com/eslint/eslint/issues?q=is%3Aopen+is%3Aissue+label%3Arelease |
This only fixes the crash issue, but does not fix how the overrides is handled when it comes from a plugin/config, right? |
Correct. This fixes only the crash caused by the assertion error in |
Should we open an issue for the part which handles the overrides coming from the configs located in npm packages? |
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
What changes did you make? (Give an overview)
This PR fixes #12032.
The cause was the reuse of
OverrideTester
instances in spite of mutable.Is there anything you'd like reviewers to focus on?
Nothing in particular.