New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: actual messageId and expected messageId are switched in rule tester #11928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing!
Small nit: I think this could be called a bugfix rather than a chore since RuleTester is a public API/tool (albeit used by rule developers), but I don't feel strongly about changing the commit message. Maybe we could change the commit message on merge. |
Sorry, my mistake, I read the guide about commit messages (Chore - ... anything that isn’t user-facing) and wrongly interpreted 'user' (like, someone who needs only 'User guide' menu from the website). I'll change the message and PR title. |
No need to apologize, we get it wrong sometimes too :) |
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain: Small fix in rule tester
ESLint Version: master
What did you do? Please include the actual source code causing the issue.
Add the following test example to
tests/lib/rules/dot-location.js
:What did you expect to happen?
What actually happened? Please include the actual, raw output from ESLint.
What changes did you make? (Give an overview)
Switched args in rule tester.
Is there anything you'd like reviewers to focus on?