Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: fix config loading (fixes #11510, fixes #11559, fixes #11586) #11546

Merged
merged 53 commits into from
May 10, 2019
Merged

Breaking: fix config loading (fixes #11510, fixes #11559, fixes #11586) #11546

merged 53 commits into from
May 10, 2019

Commits on Apr 9, 2019

  1. Breaking: fix config loading (fixes #11510, fixes #11559, fixes #11586)

    @mysticatea
    mysticatea committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    ea25be2 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. fix typo 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    ef57db3 View commit details
    Browse the repository at this point in the history

  2. clarify a magic number 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    69566ee View commit details
    Browse the repository at this point in the history

  3. correct a comment 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    8157464 View commit details
    Browse the repository at this point in the history

  4. correct a test description 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    d96176f View commit details
    Browse the repository at this point in the history

  5. fix typo 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    11f293d View commit details
    Browse the repository at this point in the history

  6. fix typo 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f6eb5fa View commit details
    Browse the repository at this point in the history

  7. fix typo 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    d6538e7 View commit details
    Browse the repository at this point in the history

  8. fix a copy/paste mistake 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    f51d2c0 View commit details
    Browse the repository at this point in the history

  9. fix typo 

    Co-Authored-By: mysticatea <star.ctor@gmail.com>
    @platinumazure @mysticatea
    platinumazure and mysticatea committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    bedce88 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. remove "a.js" from getConfigForFile (#11546 (comment))

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    95d3dc2 View commit details
    Browse the repository at this point in the history

  2. remove commented out debug.enabled=true

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    6a13317 View commit details
    Browse the repository at this point in the history

  3. fix CascadingConfigArrayFactoryOptions#cliConfig comment

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    fa671b8 View commit details
    Browse the repository at this point in the history

  4. originalEnabled → originalDebugEnabled

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    e743a71 View commit details
    Browse the repository at this point in the history

  5. fix a test description (#11546 (comment))

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    ef65825 View commit details
    Browse the repository at this point in the history

  6. remove "Moved from *" groups 

    Please check this diff with `-w` flag.
    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    c1f7075 View commit details
    Browse the repository at this point in the history

  7. Inmemory → InMemory

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    80d55d6 View commit details
    Browse the repository at this point in the history

  8. remove JSON.stringify(files) from test subjects

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    41f0d91 View commit details
    Browse the repository at this point in the history

  9. remove shadowing variables

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    f8e3102 View commit details
    Browse the repository at this point in the history

  10. update wrong JSDoc comment

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    3df21e8 View commit details
    Browse the repository at this point in the history

  11. remove a workaround for Node 6

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    f8f6950 View commit details
    Browse the repository at this point in the history

  12. make factory instance unique for each test case

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    d1c2752 View commit details
    Browse the repository at this point in the history

  13. add a test case for root

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    75c5157 View commit details
    Browse the repository at this point in the history

  14. fix a test case more readable

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    8a2772e View commit details
    Browse the repository at this point in the history

  15. improve tests for JSON.stringify and console.log

    @mysticatea
    mysticatea committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    6ea6c1e View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2019

  1. Merge branch 'master' into issue11510 

    # Conflicts:
#	package.json
#	tests/lib/config/config-file.js
    @mysticatea
    mysticatea committed Apr 13, 2019
    Configuration menu
    Copy the full SHA
    6f97db3 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Merge branch 'master' into issue11510

    @mysticatea
    mysticatea committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    db764bb View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2019

  1. Merge branch 'master' into issue11510

    @mysticatea
    mysticatea committed Apr 27, 2019
    Configuration menu
    Copy the full SHA
    45f724e View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. fix typo 

    Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>
    @mysticatea @not-an-aardvark
    mysticatea and not-an-aardvark committed May 9, 2019
    Configuration menu
    Copy the full SHA
    5bc6da0 View commit details
    Browse the repository at this point in the history

  2. "on" → "in" in a comment 

    Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>
    @mysticatea @not-an-aardvark
    mysticatea and not-an-aardvark committed May 9, 2019
    Configuration menu
    Copy the full SHA
    abdea3e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issue11510

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    c04ead2 View commit details
    Browse the repository at this point in the history

  4. change verifyText parameter to an object

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    511da78 View commit details
    Browse the repository at this point in the history

  5. add a comment about basename and resultFilePath

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    6a3c384 View commit details
    Browse the repository at this point in the history

  6. simplify dirSuffix

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    bfc25ec View commit details
    Browse the repository at this point in the history

  7. "on" → "in" in an error message 

    Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>
    @mysticatea @not-an-aardvark
    mysticatea and not-an-aardvark committed May 9, 2019
    Configuration menu
    Copy the full SHA
    57774b4 View commit details
    Browse the repository at this point in the history

  8. remove the default value from `CascadingConfigArrayFactory#getConfigA… 

    …rrayForFile()` method
    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    49d1461 View commit details
    Browse the repository at this point in the history

  9. freeze cached config arrays

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    bdb3123 View commit details
    Browse the repository at this point in the history

  10. "*OnDirectory" → "*InDirectory"

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    4fae2b2 View commit details
    Browse the repository at this point in the history

  11. normalize plugins in _loadPlugin method

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    3447120 View commit details
    Browse the repository at this point in the history

  12. rename placeholder filename

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    6f5269b View commit details
    Browse the repository at this point in the history

  13. remove unnecessary if for local plugins

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    b5c0285 View commit details
    Browse the repository at this point in the history

  14. add more check for __proto__

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    396ff47 View commit details
    Browse the repository at this point in the history

  15. "mergeRules" → "mergeRuleConfigs"

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    55fd2da View commit details
    Browse the repository at this point in the history

  16. "root" → "isRoot()"

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    5a2453d View commit details
    Browse the repository at this point in the history

  17. add assertion for basePath in OverrideTester.and()

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    f8cd098 View commit details
    Browse the repository at this point in the history

  18. Update lib/config/config-initializer.js 

    Co-Authored-By: Teddy Katz <teddy.katz@gmail.com>
    @mysticatea @not-an-aardvark
    mysticatea and not-an-aardvark committed May 9, 2019
    Configuration menu
    Copy the full SHA
    bc23404 View commit details
    Browse the repository at this point in the history

  19. "builtInRules.keys()" → "builtInRules.entries()"

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    eb5164a View commit details
    Browse the repository at this point in the history

  20. "Function.prototype" → "noop"

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    810dd77 View commit details
    Browse the repository at this point in the history

  21. remove unnecessary lodash.cloneDeep

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    fb5c29a View commit details
    Browse the repository at this point in the history

  22. fix about <text>

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    a852b02 View commit details
    Browse the repository at this point in the history

  23. fix getConfigForFile() to require an argument

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    1fda3f2 View commit details
    Browse the repository at this point in the history

  24. builtInRules.entries() → builtInRules

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    40925c0 View commit details
    Browse the repository at this point in the history

  25. update migration guide

    @mysticatea
    mysticatea committed May 9, 2019
    Configuration menu
    Copy the full SHA
    fcf8228 View commit details
    Browse the repository at this point in the history