-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: eslint:recommended changes (fixes #10768) #11518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from a small suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Adding "do not merge" for now to make sure we agree on the rule suggestions from #10768 (comment) before merging. |
What is the purpose of this pull request? (put an "X" next to item)
[x ] Other, please explain: fixes #10768
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
any objections on the rules?