Breaking: make no-redeclare stricter (fixes #11370, fixes #11405) #11509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement eslint/rfcs#17 - Fixes #11370 - Remvoes the access to parserOptions from no-redeclare rule - Adds several tests for lexical bindings to no-redeclare rule
mysticatea
added
enhancement
not-an-aardvark
previously requested changes
Mar 15, 2019
Co-Authored-By: mysticatea <star.ctor@gmail.com>
# Conflicts: # tests/lib/rules/no-redeclare.js
platinumazure
requested changes
Mar 28, 2019
There was a problem hiding this comment.
Left a few small suggestions.
I'm a little leery about consuming acorn in ESLint, but there's probably not much choice here. Part of me wonders if we should expose a loose parsing mode in espree and just use that, but maybe that would just be a support headache as people ask us about issues involving loose espree...
Co-Authored-By: mysticatea <star.ctor@gmail.com>
Co-Authored-By: mysticatea <star.ctor@gmail.com>
# Conflicts: # lib/config/config-ops.js # lib/linter.js # tests/lib/config/config-ops.js
not-an-aardvark
dismissed
their stale review
I'm not sure when I'll have time to review this thoroughly, but my previous review has been addressed.
# Conflicts: # package.json
platinumazure
approved these changes
Apr 24, 2019
|
Thank you very much! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Changes an existing rule
[X] Add something to the core
What changes did you make? (Give an overview)
This PR makes
no-redeclarerule stricter./*globals*/comment check tono-redeclarerule. (Proposal: no-redeclare reports /*globals foo*/ comments if it's redeclaration #11370){ builtinGlobals: true }option by default. (Proposal: change no-redeclare default behavior #11405)Adds some items to the migration guide.(moved to Docs: add v6.0.0 migration guide #11515)And some chore:
parserOptionsfromno-redeclarerule. TheparserOptionsis not safe because each parser has different options./*globals*/comments toast-utilsbecause it's shared withno-unused-varsrule andno-redeclarerule.no-redeclarerule along with a loose parser that doesn't throw syntax errors on redeclaration of lexical bindings.Makes(moved to Chore: make test-case-property-ordering reasonable #11511)eslint-plugin/test-case-property-orderingrule's option more reasonable.Is there anything you'd like reviewers to focus on?
no-redeclarerule handle lexical bindings still? Since acorn 5.0.0, it throws syntax errors by such a redeclaration.