Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: implicit-arrow-linebreak adds extra characters (fixes #11268) #11407

Merged
merged 12 commits into from Mar 15, 2019
Merged

Fix: implicit-arrow-linebreak adds extra characters (fixes #11268) #11407

merged 12 commits into from Mar 15, 2019

Commits on Feb 7, 2019

  1. add failing test case

    @peanutenthusiast
    peanutenthusiast committed Feb 7, 2019
    Copy the full SHA
    08d151b View commit details
    Browse the repository at this point in the history

  2. Add specified test case from issue

    @peanutenthusiast
    peanutenthusiast committed Feb 7, 2019
    Copy the full SHA
    7fa291f View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2019

  1. Remove calculation for white spaces from formatComments and addParent… 

    …heses, add condition to check for arrow expressions with block statements
    @peanutenthusiast
    peanutenthusiast committed Feb 16, 2019
    Copy the full SHA
    b367423 View commit details
    Browse the repository at this point in the history

  2. Fix linting errors, ensure npm test runs without fail

    @peanutenthusiast
    peanutenthusiast committed Feb 16, 2019
    Copy the full SHA
    3567086 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2019

  1. Change new test case to check for prepended comment, add unIndent fun… 

    …ction to tests for implicit arrow linebreak
    @peanutenthusiast
    peanutenthusiast committed Feb 17, 2019
    Copy the full SHA
    752bc30 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Add optional token type to arrow body

    @peanutenthusiast
    peanutenthusiast committed Feb 20, 2019
    Copy the full SHA
    f946d72 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Add failing test case

    @peanutenthusiast
    peanutenthusiast committed Feb 28, 2019
    Copy the full SHA
    727039e View commit details
    Browse the repository at this point in the history

  2. Remove null return from autofixBesides, refactor body setting lines t… 

    …o use .body
    @peanutenthusiast
    peanutenthusiast committed Feb 28, 2019
    Copy the full SHA
    a330080 View commit details
    Browse the repository at this point in the history

  3. Fix linting errors

    @peanutenthusiast
    peanutenthusiast committed Feb 28, 2019
    Copy the full SHA
    84e6b3d View commit details
    Browse the repository at this point in the history

  4. Fix linting error in unIndent rule in implicit arrow linebreak test

    @peanutenthusiast
    peanutenthusiast committed Feb 28, 2019
    Copy the full SHA
    99ae4fc View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. Add another test case where nested arrow function contains block stat… 

    …ement
    dios committed Mar 11, 2019
    Copy the full SHA
    0a9e8ca View commit details
    Browse the repository at this point in the history

  2. Add constraint for block statement in add parentheses

    dios committed Mar 11, 2019
    Copy the full SHA
    4267ecc View commit details
    Browse the repository at this point in the history