Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: clarify motivation for no-prototype-builtins #11356

Merged
merged 2 commits into from Feb 7, 2019
Merged

Docs: clarify motivation for no-prototype-builtins #11356

merged 2 commits into from Feb 7, 2019

Commits on Feb 6, 2019

  1. Docs: clarify motivation for no-prototype-builtins 

    The first section in the no-prototype-builtins docs mentions objects created with Object.create(null), but does not mention builtin shadowing (which is arguably a much more compelling reason to use the rule). This commit updates the description to clarify the risks of using prototype builtins on user input.
    @not-an-aardvark
    not-an-aardvark committed Feb 6, 2019
    Copy the full SHA
    ed5684d View commit details
    Browse the repository at this point in the history

  2. Update "When not to use it" wording

    @not-an-aardvark
    not-an-aardvark committed Feb 6, 2019
    Copy the full SHA
    658d6a6 View commit details
    Browse the repository at this point in the history