Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: update incorrect tests to fix build failing #11354

Merged
merged 4 commits into from Feb 5, 2019
Merged

Chore: update incorrect tests to fix build failing #11354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
171e6b6
Chore: fix exports in comma-dangle tests
aladdin-add Feb 4, 2019
14c6eaf
Upgrade: acorn@6.0.7
aladdin-add Feb 4, 2019
1b0d9b4
Update package.json
aladdin-add Feb 4, 2019
290bd24
Chore: revert unexpected change
aladdin-add Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 10 additions & 10 deletions tests/lib/rules/comma-dangle.js
View file
Open in desktop
Expand Up @@ -1290,12 +1290,12 @@ ruleTester.run("comma-dangle", rule, {
code: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
output: `let {a} = {a: 1};
let [b,] = [1,];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
options: [{
objects: "never",
Expand All @@ -1314,12 +1314,12 @@ export {d,};
code: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
output: `let {a,} = {a: 1,};
let [b] = [1];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
options: [{
objects: "ignore",
Expand All @@ -1338,12 +1338,12 @@ export {d,};
code: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
output: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
options: [{
objects: "ignore",
Expand All @@ -1361,12 +1361,12 @@ export {d,};
code: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
output: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c,} from "foo";
export {d};
let d = 0;export {d};
(function foo(e,) {})(f,);`,
options: [{
objects: "ignore",
Expand All @@ -1384,12 +1384,12 @@ export {d};
code: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e,) {})(f,);`,
output: `let {a,} = {a: 1,};
let [b,] = [1,];
import {c,} from "foo";
export {d,};
let d = 0;export {d,};
(function foo(e) {})(f);`,
options: [{
objects: "ignore",
Expand Down
15 changes: 12 additions & 3 deletions tests/lib/rules/indent.js
View file
Open in desktop
Expand Up @@ -1109,6 +1109,7 @@ ruleTester.run("indent", rule, {
},
{
code: unIndent`
var foo = 0, bar = 0; baz = 0;
export {
foo,
bar,
Expand Down Expand Up @@ -3100,6 +3101,7 @@ ruleTester.run("indent", rule, {
`,
{
code: unIndent`
var foo = 0, bar = 0, baz = 0;
export {
foo,
bar,
Expand Down Expand Up @@ -4813,6 +4815,7 @@ ruleTester.run("indent", rule, {
},
{
code: unIndent`
var a = 0, b = 0, c = 0;
export default foo(
a,
b, {
Expand Down Expand Up @@ -7620,39 +7623,43 @@ ruleTester.run("indent", rule, {
},
{
code: unIndent`
var foo = 0, bar = 0, baz = 0;
export {
foo,
bar,
baz
};
`,
output: unIndent`
var foo = 0, bar = 0, baz = 0;
export {
foo,
bar,
baz
};
`,
parserOptions: { sourceType: "module" },
errors: expectedErrors([[2, 4, 0, "Identifier"], [3, 4, 2, "Identifier"]])
errors: expectedErrors([[3, 4, 0, "Identifier"], [4, 4, 2, "Identifier"]])
},
{
code: unIndent`
var foo = 0, bar = 0, baz = 0;
export {
foo,
bar,
baz
} from 'qux';
`,
output: unIndent`
var foo = 0, bar = 0, baz = 0;
export {
foo,
bar,
baz
} from 'qux';
`,
parserOptions: { sourceType: "module" },
errors: expectedErrors([[2, 4, 0, "Identifier"], [3, 4, 2, "Identifier"]])
errors: expectedErrors([[3, 4, 0, "Identifier"], [4, 4, 2, "Identifier"]])
},
{

Expand Down Expand Up @@ -8074,21 +8081,23 @@ ruleTester.run("indent", rule, {
},
{
code: unIndent`
var foo = 0, bar = 0, baz = 0;
export {
foo,
bar,
baz
}
`,
output: unIndent`
var foo = 0, bar = 0, baz = 0;
export {
foo,
bar,
baz
}
`,
parserOptions: { sourceType: "module" },
errors: expectedErrors([[2, 4, 0, "Identifier"], [3, 4, 8, "Identifier"], [4, 4, 2, "Identifier"]])
errors: expectedErrors([[3, 4, 0, "Identifier"], [4, 4, 8, "Identifier"], [5, 4, 2, "Identifier"]])
},
{
code: unIndent`
Expand Down
36 changes: 18 additions & 18 deletions tests/lib/rules/keyword-spacing.js
View file
Open in desktop
Expand Up @@ -561,16 +561,16 @@ ruleTester.run("keyword-spacing", rule, {
// export
//----------------------------------------------------------------------

{ code: "{} export {a}", parserOptions: { sourceType: "module" } },
{ code: "var a = 0; {} export {a}", parserOptions: { sourceType: "module" } },
{ code: "{} export default a", parserOptions: { sourceType: "module" } },
{ code: "{} export * from \"a\"", parserOptions: { sourceType: "module" } },
{ code: "{}export{a}", options: [NEITHER], parserOptions: { sourceType: "module" } },
{ code: "{} export {a}", options: [override("export", BOTH)], parserOptions: { sourceType: "module" } },
{ code: "{}export{a}", options: [override("export", NEITHER)], parserOptions: { sourceType: "module" } },
{ code: "var a = 0; {}export{a}", options: [NEITHER], parserOptions: { sourceType: "module" } },
{ code: "var a = 0; {} export {a}", options: [override("export", BOTH)], parserOptions: { sourceType: "module" } },
{ code: "var a = 0; {}export{a}", options: [override("export", NEITHER)], parserOptions: { sourceType: "module" } },

// not conflict with `semi-spacing`
{ code: ";export {a}", parserOptions: { sourceType: "module" } },
{ code: "; export{a}", options: [NEITHER], parserOptions: { sourceType: "module" } },
{ code: "var a = 0;\n;export {a}", parserOptions: { sourceType: "module" } },
{ code: "var a = 0;\n; export{a}", options: [NEITHER], parserOptions: { sourceType: "module" } },

//----------------------------------------------------------------------
// extends
Expand Down Expand Up @@ -2012,20 +2012,20 @@ ruleTester.run("keyword-spacing", rule, {
//----------------------------------------------------------------------

{
code: "{}export{a}",
output: "{} export {a}",
code: "var a = 0; {}export{a}",
output: "var a = 0; {} export {a}",
parserOptions: { sourceType: "module" },
errors: expectedBeforeAndAfter("export")
},
{
code: "{}export default a",
output: "{} export default a",
code: "var a = 0; {}export default a",
output: "var a = 0; {} export default a",
parserOptions: { sourceType: "module" },
errors: expectedBefore("export")
},
{
code: "export default{a}",
output: "export default {a}",
code: "var a = 0; export default{a}",
output: "var a = 0; export default {a}",
parserOptions: { sourceType: "module" },
errors: expectedAfter("default")
},
Expand All @@ -2036,22 +2036,22 @@ ruleTester.run("keyword-spacing", rule, {
errors: expectedBeforeAndAfter("export")
},
{
code: "{} export {a}",
output: "{}export{a}",
code: "var a = 0; {} export {a}",
output: "var a = 0; {}export{a}",
options: [NEITHER],
parserOptions: { sourceType: "module" },
errors: unexpectedBeforeAndAfter("export")
},
{
code: "{}export{a}",
output: "{} export {a}",
code: "var a = 0; {}export{a}",
output: "var a = 0; {} export {a}",
options: [override("export", BOTH)],
parserOptions: { sourceType: "module" },
errors: expectedBeforeAndAfter("export")
},
{
code: "{} export {a}",
output: "{}export{a}",
code: "var a = 0; {} export {a}",
output: "var a = 0; {}export{a}",
options: [override("export", NEITHER)],
parserOptions: { sourceType: "module" },
errors: unexpectedBeforeAndAfter("export")
Expand Down
13 changes: 9 additions & 4 deletions tests/lib/rules/no-irregular-whitespace.js
View file
Open in desktop
Expand Up @@ -181,10 +181,15 @@ ruleTester.run("no-irregular-whitespace", rule, {
code: "var any \u00A0 = 'thing';",
errors: expectedErrors
},
{
code: "var any \u180E = 'thing';",
errors: expectedErrors
},

/*
* it was moved out of General_Category=Zs (separator, space) in Unicode 6.3.0, so should not be considered a whitespace character.
* https://codeblog.jonskeet.uk/2014/12/01/when-is-an-identifier-not-an-identifier-attack-of-the-mongolian-vowel-separator/
* {
* code: "var any \u180E = 'thing';",
* errors: expectedErrors
* },
*/
{
code: "var any \ufeff = 'thing';",
errors: expectedErrors
Expand Down
14 changes: 9 additions & 5 deletions tests/lib/rules/no-undefined.js
View file
Open in desktop
Expand Up @@ -111,11 +111,15 @@ ruleTester.run("no-undefined", rule, {
parserOptions: ES6_MODULE,
errors
},
{
code: "export { undefined }",
parserOptions: ES6_MODULE,
errors
},

/*
* it will be warned "Parsing error: Export 'undefined' is not defined" (acorn@>=6.0.7)
* {
* code: "export { undefined }",
* parserOptions: ES6_MODULE,
* errors
* },
*/
{ code: "let a = [b, ...undefined]", errors },
{ code: "[a, ...undefined] = b", errors },
{ code: "[a = undefined] = b", errors }
Expand Down
30 changes: 15 additions & 15 deletions tests/lib/rules/no-useless-rename.js
View file
Open in desktop
Expand Up @@ -44,8 +44,8 @@ ruleTester.run("no-useless-rename", rule, {
"import {foo as bar} from 'foo';",
"import {foo as bar, baz as qux} from 'foo';",
"export {foo} from 'foo';",
"export {foo as bar};",
"export {foo as bar, baz as qux};",
"var foo = 0;export {foo as bar};",
"var foo = 0; var baz = 0; export {foo as bar, baz as qux};",
"export {foo as bar} from 'foo';",
"export {foo as bar, baz as qux} from 'foo';",
{
Expand Down Expand Up @@ -91,15 +91,15 @@ ruleTester.run("no-useless-rename", rule, {

// { ignoreExport: true }
{
code: "export {foo as foo};",
code: "var foo = 0;export {foo as foo};",
options: [{ ignoreExport: true }]
},
{
code: "export {foo as foo, bar as baz};",
code: "var foo = 0;var bar = 0;export {foo as foo, bar as baz};",
options: [{ ignoreExport: true }]
},
{
code: "export {foo as foo, bar as bar};",
code: "var foo = 0;var bar = 0;export {foo as foo, bar as bar};",
options: [{ ignoreExport: true }]
},
{
Expand Down Expand Up @@ -261,23 +261,23 @@ ruleTester.run("no-useless-rename", rule, {
errors: ["Import foo unnecessarily renamed.", "Import bar unnecessarily renamed."]
},
{
code: "export {foo as foo};",
output: "export {foo};",
code: "var foo = 0; export {foo as foo};",
output: "var foo = 0; export {foo};",
errors: ["Export foo unnecessarily renamed."]
},
{
code: "export {foo as foo, bar as baz};",
output: "export {foo, bar as baz};",
code: "var foo = 0; var bar = 0; export {foo as foo, bar as baz};",
output: "var foo = 0; var bar = 0; export {foo, bar as baz};",
errors: ["Export foo unnecessarily renamed."]
},
{
code: "export {foo as bar, baz as baz};",
output: "export {foo as bar, baz};",
code: "var foo = 0; var baz = 0; export {foo as bar, baz as baz};",
output: "var foo = 0; var baz = 0; export {foo as bar, baz};",
errors: ["Export baz unnecessarily renamed."]
},
{
code: "export {foo as foo, bar as bar};",
output: "export {foo, bar};",
code: "var foo = 0; var bar = 0;export {foo as foo, bar as bar};",
output: "var foo = 0; var bar = 0;export {foo, bar};",
errors: ["Export foo unnecessarily renamed.", "Export bar unnecessarily renamed."]
},
{
Expand All @@ -291,8 +291,8 @@ ruleTester.run("no-useless-rename", rule, {
errors: ["Export foo unnecessarily renamed."]
},
{
code: "export {foo as bar, baz as baz} from 'foo';",
output: "export {foo as bar, baz} from 'foo';",
code: "var foo = 0; var bar = 0; export {foo as bar, baz as baz} from 'foo';",
output: "var foo = 0; var bar = 0; export {foo as bar, baz} from 'foo';",
errors: ["Export baz unnecessarily renamed."]
},
{
Expand Down