wip: Chore: switch to eslint-plugin-jsdoc (refs #11146) #11147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
added
accepted
|
I think we should maybe not rely on the |
|
It would be great if there is a new ruleset in |
aladdin-add
force-pushed
the
chore/eslint-plugin-jsdoc
branch
from
6332364
to
9c25de8
Compare
|
According to gajus/eslint-plugin-jsdoc#107 (comment), it looks like those changes have now been released! |
|
I'm closing this PR since #12332 has switched to the plugin. Thank you. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x ] Other, please explain:
What changes did you make? (Give an overview)
start to using
eslint-plugin-jsdoc, sincevalid-jsdocandrequire-jsdochas been deprecated.Is there anything you'd like reviewers to focus on?
just a wip, we might have to disable some rules in
jsdoc/recommended, since there is a large number of linting errors to fix.the original errors: https://ci.appveyor.com/project/nzakas/eslint/builds/20697383