Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: "off" options for "space-before-blocks" (refs #10906) #10907

Merged
merged 2 commits into from Nov 9, 2018
Merged

Update: "off" options for "space-before-blocks" (refs #10906) #10907

merged 2 commits into from Nov 9, 2018

Commits on Oct 1, 2018

  1. Update: "off" options for "space-before-blocks" (refs eslint#10906) 

    See eslint#10906

Where "always" enforces space and "never" enforces no-space, "off" does not enforce any space preference.

It may be useful to add a similar "off" option to other enums only allowing "always" and "never", too, but that is outside the scope of this PR.

TODO: Why do two tests fail? (what the heck???)
TODO: The documentation will need to describe this addition in more detail.
    @pineapplemachine
    pineapplemachine committed Oct 1, 2018
    Copy the full SHA
    ea987a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. Fix: Tests pass for space-before-blocks rule change (refs eslint#10907) 

    I somehow managed to insert "No" into totally the wrong place in that last commit...
    @pineapplemachine
    pineapplemachine committed Oct 2, 2018
    Copy the full SHA
    d130db8 View commit details
    Browse the repository at this point in the history