Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: Warn for dangling commas #13

Closed
nzakas opened this issue Jul 6, 2013 · 5 comments
Closed

Rule: Warn for dangling commas #13

nzakas opened this issue Jul 6, 2013 · 5 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@nzakas
Copy link
Member

nzakas commented Jul 6, 2013

This rule should warn when a dangling comma is found in object literal syntax:

var o = {
    prop: value,
};

The rule ID should be "no-dangle"

Man I love this rule ID. :)
iancmyers added a commit to iancmyers/eslint that referenced this issue Jul 19, 2013
@iancmyers
Created no-dangle rule.
4f6169f 
Created the no-dangle rule, which warns when it encounters a trailing comma in an object literal. The following will raise warnings:

var foo = {
  bar: "baz",
}

Fixes issue eslint#13
@iancmyers iancmyers mentioned this issue Jul 19, 2013
Merged
iancmyers added a commit to iancmyers/eslint that referenced this issue Jul 19, 2013
@iancmyers
Created no-dangle rule.
410a00f 
Created the no-dangle rule, which warns when it encounters a trailing comma in an object literal. The following will raise warnings:

var foo = {
  bar: "baz",
}

Fixes issue eslint#13
iancmyers added a commit to iancmyers/eslint that referenced this issue Jul 19, 2013
@iancmyers
Created no-dangle rule.
8262223 
Created the no-dangle rule, which warns when it encounters a trailing comma in an object literal. The following will raise warnings:

var foo = {
  bar: "baz",
}

Fixes issue eslint#13
@iancmyers
Copy link
Contributor

I believe this issue can be closed.

@nzakas
Copy link
Member Author

nzakas commented Jul 21, 2013

Yes it can. Please be sure to say "(fixes #13)" in your commit messages from now on so GitHub will automatically close the issue when merged (this is in the contributor guide).

@nzakas nzakas closed this as completed Jul 21, 2013
@iancmyers
Copy link
Contributor

@nzakas does it have to be EXACTLY "(fixes #13)", because I had "Fixes issue #13" in there?

iancmyers@8262223

@michaelficarra
Copy link
Member

@iancmyers: https://github.com/blog/1386-closing-issues-via-commit-messages

@nzakas
Copy link
Member Author

nzakas commented Jul 22, 2013

That extra "issue" messes it up. No other words between "fixes" and the issue number.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 7, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @iancmyers @michaelficarra