Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support "bigint" in valid-typeof rule #11802

Merged
merged 2 commits into from Jun 8, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 4, 2019

BigInt just moved to Stage 4, so add support for it to the valid-typeof rule.

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?
valid-typeof

Does this change cause the rule to produce more or fewer warnings?
fewer

How will the change be implemented? (New option, new default behavior, etc.)?
A new valid typeof value, 'bigint', is added.

Please provide some example code that this change will affect:

if (typeof foo === 'bigint') {
  console.log('bigint');
}

What does the rule currently do for this code?
Reports an error.

What will the rule do after it's changed?
Accept bigint as a valid typeof value.

What changes did you make? (Give an overview)
Added a new typeof value to the rule, test, and docs.

Is there anything you'd like reviewers to focus on?
Nothing particular.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 4, 2019
@aladdin-add aladdin-add added enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jun 4, 2019
BigInt just moved to Stage 4, so add support for it to
the valid-typeof rule.
@mysticatea mysticatea added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 4, 2019
This commit adds a Further Reading section to the
valid-typeof rule documentation.
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ilyavolodin ilyavolodin merged commit e4ab053 into eslint:master Jun 8, 2019
@cjihrig cjihrig deleted the bigint branch June 10, 2019 02:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 6, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants