Update: support "bigint" in valid-typeof rule

BigInt just moved to Stage 4, so add support for it to the valid-typeof rule.
eslint · Jun 4, 2019 · cefbb2d · cefbb2d
1 parent cb1922b
commit cefbb2d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/docs/rules/valid-typeof.md b/docs/rules/valid-typeof.md
@@ -1,6 +1,6 @@
 # enforce comparing `typeof` expressions against valid strings (valid-typeof)
 
-For a vast majority of use cases, the result of the `typeof` operator is one of the following string literals: `"undefined"`, `"object"`, `"boolean"`, `"number"`, `"string"`, `"function"` and `"symbol"`. It is usually a typing mistake to compare the result of a `typeof` operator to other string literals.
+For a vast majority of use cases, the result of the `typeof` operator is one of the following string literals: `"undefined"`, `"object"`, `"boolean"`, `"bigint"`, `"number"`, `"string"`, `"function"` and `"symbol"`. It is usually a typing mistake to compare the result of a `typeof` operator to other string literals.
 
 ## Rule Details
 

diff --git a/lib/rules/valid-typeof.js b/lib/rules/valid-typeof.js
@@ -39,7 +39,7 @@ module.exports = {
 
     create(context) {
 
-        const VALID_TYPES = ["symbol", "undefined", "object", "boolean", "number", "string", "function"],
+        const VALID_TYPES = ["symbol", "undefined", "object", "boolean", "bigint", "number", "string", "function"],
             OPERATORS = ["==", "===", "!=", "!=="];
 
         const requireStringLiterals = context.options[0] && context.options[0].requireStringLiterals;

diff --git a/tests/lib/rules/valid-typeof.js b/tests/lib/rules/valid-typeof.js
@@ -25,6 +25,7 @@ ruleTester.run("valid-typeof", rule, {
         "typeof foo === 'function'",
         "typeof foo === 'undefined'",
         "typeof foo === 'boolean'",
+        "typeof foo === 'bigint'",
         "typeof foo === 'number'",
         "'string' === typeof foo",
         "'object' === typeof foo",