Upgrade: CircularJSON dependency warning #11314

Teamop · 2019-01-24T12:37:34Z

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Update Dependency

What changes did you make? (Give an overview)
Update file-entry-cache to v4 to avoid the CircularJSON dependency warning, along with updating the test cases to parse the content using flatted which is used to create cache.

Is there anything you'd like reviewers to focus on?
close #11052

jsf-clabot · 2019-01-24T12:37:35Z

All committers have signed the CLA.

g-plane

@Teamop Can you check why did the CI fail? Thanks.

tests/lib/cli-engine.js

Teamop · 2019-01-24T16:47:10Z

tests/bin/eslint.js

-                // Update the file to change its mtime
-                fs.writeFileSync(SOURCE_PATH, fs.readFileSync(SOURCE_PATH, "utf8"));
+                // Update the file to add one blank space
+                fs.writeFileSync(SOURCE_PATH, fs.readFileSync(SOURCE_PATH, "utf8").concat(" "));


this change is for the changes in file-entry-cache Use content checksum instead of mtime and fsize

I have concerns about the performance impact of this. It seems like reading all files from the filesystem would significantly hurt performance when linting with a cache file.

(It also has the effect that we would be reading most files from the filesystem twice when we lint them, so it seems like we could get a significant performance boost by just implementing caching ourselves.)

@not-an-aardvark I did realize we merged the content checksum check instead of the mtime/size and was thinking to actually make that optional, to keep the original behavior. That's why that was released as a major version and not a minor one.

tests/lib/cli-engine.js

Teamop · 2019-01-24T16:50:20Z

CI passed, thanks

aladdin-add · 2019-01-29T22:01:04Z

as described in #11314 (comment), it could be a breaking change.

not-an-aardvark · 2019-01-29T22:07:46Z

tests/bin/eslint.js

-                // Update the file to change its mtime
-                fs.writeFileSync(SOURCE_PATH, fs.readFileSync(SOURCE_PATH, "utf8"));
+                // Update the file to add one blank space
+                fs.writeFileSync(SOURCE_PATH, fs.readFileSync(SOURCE_PATH, "utf8").concat(" "));


I have concerns about the performance impact of this. It seems like reading all files from the filesystem would significantly hurt performance when linting with a cache file.

(It also has the effect that we would be reading most files from the filesystem twice when we lint them, so it seems like we could get a significant performance boost by just implementing caching ourselves.)

tests/lib/cli-engine.js

royriojas · 2019-02-01T18:04:22Z

@Teamop my feedback

we should try to not modify the eslint tests, I prefer to file a ticket on file-entry-cache and make the checksum check optional. It was intended to be like that but I don't really recall why we didn't do it optional.
We should not use flatted to read the cache, we can use the file-entry-cache#createFromFile method to create another instance of the cache and get access to the values from the .cache property in the file-entry-cache instance.

cc @platinumazure @nzakas @not-an-aardvark

Teamop · 2019-02-03T11:11:37Z

thanks @royriojas , I have used the file-entry-cache#createFromFile to get the test cases passed. The left is about the changes in file-entry-cache, the ticket in file-entry-cache is opened file-entry-cache#13

royriojas · 2019-02-04T02:21:51Z

@Teamop file-entry-cache@5.0.0 makes the md5 comparison optional. We can try in your PR to make sure we have the old behavior of using the mtime and file size.

Teamop · 2019-02-04T11:26:51Z

@royriojas I have reverted other changes, but the test cases still cannot pass, cause there's still one method you haven't reverted, file-entry-cache#reconcile this method, changes in Use content checksum instead of mtime and fsize

royriojas · 2019-02-04T17:32:40Z

@Teamop, thanks for letting me know. That's fixed now in version 5.0.1

Teamop · 2019-02-05T01:53:26Z

Right now, I have rebased, CI still failed, all errors in lib/testers/rule-tester.js, same with master, like comma-dangle, indent, no-useless-rename, seems irrelevant to the current changes.
@royriojas @not-an-aardvark @platinumazure @g-plane @aladdin-add

g-plane · 2019-02-05T02:01:04Z

That's a problem from Acorn. Another PR is solving this.

Teamop · 2019-02-05T02:05:52Z

thanks @g-plane , then I think this PR is ready

g-plane · 2019-02-05T02:13:12Z

@Teamop You can rebase again now.

Teamop · 2019-02-05T02:28:43Z

CI passed, thanks @g-plane

platinumazure

This LGTM in general.

Has anyone tried running ESLint (with --cache) on a codebase without this upgrade, then running it with --cache after checking out this commit? (I.e., has anyone confirmed the cache is totally compatible even across this upgrade?) Thanks!

royriojas · 2019-02-05T03:06:34Z

@platinumazure cache won't be compatible. A new cache will be created after the upgrade. But it is only for the first run after the upgrade then the cache should work as usual.

platinumazure · 2019-02-05T03:09:57Z

@royriojas

cache won't be compatible

And ESLint (or more precisely file-entry-cache) will just silently invalidate the cache in that case? No error thrown, no extra file in the filesystem?

Sorry for all the questions- just want to make sure the user experience is as seamless as possible! I can live with a cache invalidation as long as it's unnoticeable by our users (outside of losing the performance savings for the first run).

platinumazure · 2019-02-05T03:42:41Z

As a general note, I want to thank @Teamop, @g-plane, and @royriojas for keeping this moving even after I had raised concerns about the initial approach. Thanks so much for sticking it out and for being patient with me. Thanks also to @not-an-aardvark and @aladdin-add for providing their own feedback.

royriojas · 2019-02-05T07:09:48Z

@platinumazure

And ESLint (or more precisely file-entry-cache) will just silently invalidate the cache in that case? No error thrown, no extra file in the filesystem?

If it fails to load the cache we create a new one. No error will be thrown, and no extra file in the file system as the file will be reused for the new cache.

Sorry for all the questions- just want to make sure the user experience is as seamless as possible! I can live with a cache invalidation as long as it's unnoticeable by our users (outside of losing the performance savings for the first run).

I believe we are including the eslint version in the cache, so upgrading it should blow away the cache anyway so, no real performance hit apart from the initial one that I believe is expected anyway.

## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.12.1` to `5.14.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v5.14.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> Fix: adds conditional for separateRequires in one-var (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310933694" data-permission-text="Issue title is private" data-url="eslint/eslint#10179" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10179/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10179">#10179</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="369993599" data-permission-text="Issue title is private" data-url="eslint/eslint#10980" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10980/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10980">#10980</a>) (Scott Stern)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> Upgrade: espree@5.0.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410918526" data-permission-text="Issue title is private" data-url="eslint/eslint#11401" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11401/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11401">#11401</a>) (Ilya Volodin)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> Docs: Update governance doc with reviewers status (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410806033" data-permission-text="Issue title is private" data-url="eslint/eslint#11399" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11399/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11399">#11399</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> Fix: Support boundary spread elements in sort-keys (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387528357" data-permission-text="Issue title is private" data-url="eslint/eslint#11158" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11158/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11158">#11158</a>) (Jakub Rożek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="176681678" data-permission-text="Issue title is private" data-url="eslint/eslint#7145" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/7145/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/7145">#7145</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="396278013" data-permission-text="Issue title is private" data-url="eslint/eslint#11243" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11243/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11243">#11243</a>) (richie3366)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> Fix: comma-spacing ignore comma before closing paren (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401050405" data-permission-text="Issue title is private" data-url="eslint/eslint#11295" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11295/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11295">#11295</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408608672" data-permission-text="Issue title is private" data-url="eslint/eslint#11374" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11374/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11374">#11374</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> Docs: fix space-before-blocks correct code for "classes": "never" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410161351" data-permission-text="Issue title is private" data-url="eslint/eslint#11391" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11391/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11391">#11391</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> Docs: fix grammar in object-curly-spacing docs (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410128788" data-permission-text="Issue title is private" data-url="eslint/eslint#11389" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11389/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11389">#11389</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> Docs: fix grammar in “those who says” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410156839" data-permission-text="Issue title is private" data-url="eslint/eslint#11390" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11390/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11390">#11390</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> Docs: Add note about support for object spread (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="385126685" data-permission-text="Issue title is private" data-url="eslint/eslint#11136" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11136/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11136">#11136</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410444446" data-permission-text="Issue title is private" data-url="eslint/eslint#11395" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11395/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11395">#11395</a>) (Steven Thomas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> Update: Behavior of --init (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382337303" data-permission-text="Issue title is private" data-url="eslint/eslint#11105" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11105/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11105">#11105</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404422915" data-permission-text="Issue title is private" data-url="eslint/eslint#11332" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11332/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11332">#11332</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/550de1e611a1e9af873bcb18d74cf2056e8d2e1b"><code>550de1e</code></a> Update: use <code>default</code> keyword in JSON schema (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294113624" data-permission-text="Issue title is private" data-url="eslint/eslint#9929" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9929/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9929">#9929</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="400761608" data-permission-text="Issue title is private" data-url="eslint/eslint#11288" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11288/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11288">#11288</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/983c5201210d7a4ffab0b3d05ab9919c0754e5ca"><code>983c520</code></a> Update: Use 'readonly' and 'writable' for globals (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407305063" data-permission-text="Issue title is private" data-url="eslint/eslint#11359" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11359/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11359">#11359</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409412748" data-permission-text="Issue title is private" data-url="eslint/eslint#11384" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11384/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11384">#11384</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/f1d3a7ee7c82365989e219b1dae379f08f6dd526"><code>f1d3a7e</code></a> Upgrade: some deps (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408523961" data-permission-text="Issue title is private" data-url="eslint/eslint#11372" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11372/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11372">#11372</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408528993" data-permission-text="Issue title is private" data-url="eslint/eslint#11373" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11373/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11373">#11373</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3e0c4176eff085498b813f8ba1732d7ed6ee44f8"><code>3e0c417</code></a> Docs: Fix grammar in “there’s nothing prevent you” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409641227" data-permission-text="Issue title is private" data-url="eslint/eslint#11385" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11385/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11385">#11385</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/de988bc909b491366ad0cd9bc83f4d6de42d041a"><code>de988bc</code></a> Docs: Fix grammar: Spacing improve -> Spacing improves (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409657539" data-permission-text="Issue title is private" data-url="eslint/eslint#11386" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11386/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11386">#11386</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1309dfdebb5595460b79dcac20df6a1f109e7566"><code>1309dfd</code></a> Revert "Build: fix test failure on Node 11 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382010541" data-permission-text="Issue title is private" data-url="eslint/eslint#11100" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11100/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11100">#11100</a>)" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408638354" data-permission-text="Issue title is private" data-url="eslint/eslint#11375" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11375/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11375">#11375</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1e56897db3e254e0aef6d2fe3274157fc379c79e"><code>1e56897</code></a> Docs: “the function actually use”: use -> uses (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409158739" data-permission-text="Issue title is private" data-url="eslint/eslint#11380" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11380/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11380">#11380</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5a71bc95a7e961b1b1b77022645e0bd9cdd08dc0"><code>5a71bc9</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/82a58ce26b282fd80335b3ac4fc88f21266c3ba1"><code>82a58ce</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/546d355ace65631e27de859baea3ffcc50e0ad2c"><code>546d355</code></a> Docs: Update README with latest sponsors/team data (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408880022" data-permission-text="Issue title is private" data-url="eslint/eslint#11378" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11378/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11378">#11378</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c0df9febb7c7e045ababc10b88dbcbb3f28c724c"><code>c0df9fe</code></a> Docs: <code>...</code> is not an operator (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="395406535" data-permission-text="Issue title is private" data-url="eslint/eslint#11232" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11232/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11232">#11232</a>) (Felix Kling)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7ecfdefaeadb772f8b96ffe37c4a2c97fde0da16"><code>7ecfdef</code></a> Docs: update typescript parser (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408420749" data-permission-text="Issue title is private" data-url="eslint/eslint#11368" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11368/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11368">#11368</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408421449" data-permission-text="Issue title is private" data-url="eslint/eslint#11369" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11369/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11369">#11369</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3c90dd7e25cf97833deddb11cfbc107a5663ac08"><code>3c90dd7</code></a> Update: remove prefer-spread autofix (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404394299" data-permission-text="Issue title is private" data-url="eslint/eslint#11330" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11330/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11330">#11330</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408234262" data-permission-text="Issue title is private" data-url="eslint/eslint#11365" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11365/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11365">#11365</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5eb3121b82c1837da0c3021b7d9384bb30832e36"><code>5eb3121</code></a> Update: add fixer for <code>prefer-destructuring</code> (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="386647796" data-permission-text="Issue title is private" data-url="eslint/eslint#11151" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11151/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11151">#11151</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401382591" data-permission-text="Issue title is private" data-url="eslint/eslint#11301" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11301/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11301">#11301</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/173eb38cdb3e4673cba947521f27158828186d77"><code>173eb38</code></a> Docs: Clarify ecmaVersion doesn't imply globals (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="286511859" data-permission-text="Issue title is private" data-url="eslint/eslint#9812" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9812/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9812">#9812</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408046817" data-permission-text="Issue title is private" data-url="eslint/eslint#11364" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11364/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11364">#11364</a>) (Keith Maxwell)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/84ce72fdeba082b7b132e4ac6b714fb1a93831b7"><code>84ce72f</code></a> Fix: Remove extraneous linefeeds in <code>one-var</code> fixer (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="348084571" data-permission-text="Issue title is private" data-url="eslint/eslint#10741" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10741/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10741">#10741</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="368549184" data-permission-text="Issue title is private" data-url="eslint/eslint#10955" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10955/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10955">#10955</a>) (st-sloth)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/389362a06ac6601512b872d3e843c7371f2a1bcc"><code>389362a</code></a> Docs: clarify motivation for no-prototype-builtins (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407049599" data-permission-text="Issue title is private" data-url="eslint/eslint#11356" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11356/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11356">#11356</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/533d240b0811f663494cb213b06cc9e51e1ff2d0"><code>533d240</code></a> Update: no-shadow-restricted-names lets unassigned vars shadow undefined (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="405506188" data-permission-text="Issue title is private" data-url="eslint/eslint#11341" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11341/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11341">#11341</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d0e823aef196a6564c87a78b72c1ef980ce67af9"><code>d0e823a</code></a> Update: Make --init run js config files through linter (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294550736" data-permission-text="Issue title is private" data-url="eslint/eslint#9947" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9947/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9947">#9947</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404963393" data-permission-text="Issue title is private" data-url="eslint/eslint#11337" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11337/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11337">#11337</a>) (Brian Kurek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/92fc2f4f3faf8aeaae8a8e71db0de405404fb6c3"><code>92fc2f4</code></a> Fix: CircularJSON dependency warning (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="377112659" data-permission-text="Issue title is private" data-url="eslint/eslint#11052" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11052/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11052">#11052</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="402687981" data-permission-text="Issue title is private" data-url="eslint/eslint#11314" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11314/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11314">#11314</a>) (Terry)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4dd19a3c4c037adc860a65e96f2ba3eeccace1de"><code>4dd19a3</code></a> Docs: mention 'prefer-spread' in docs of 'no-useless-call' (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406005713" data-permission-text="Issue title is private" data-url="eslint/eslint#11348" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11348/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11348">#11348</a>) (Klaus Meinhardt)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4fd83d5ec47a6a7b81cd8801c3bd63d27ea1c7c4"><code>4fd83d5</code></a> Docs: fix a misleading example in one-var (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406350534" data-permission-text="Issue title is private" data-url="eslint/eslint#11350" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11350/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11350">#11350</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/9441ce77b7228f2c4562e158a10905afe11f31f2"><code>9441ce7</code></a> Chore: update incorrect tests to fix build failing (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406418834" data-permission-text="Issue title is private" data-url="eslint/eslint#11354" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11354/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11354">#11354</a>) (薛定谔的猫)</li> </ul> </details> <details> <summary>Commits</summary> The new version differs by 51 commits. <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b"><code>af9688b</code></a> <code>5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0ce3ac753017db813fb130d6563d524e29e20072"><code>0ce3ac7</code></a> <code>Build: changelog update for 5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> <code>Fix: adds conditional for separateRequires in one-var (fixes #10179) (#10980)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> <code>Upgrade: espree@5.0.1 (#11401)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> <code>Docs: Update governance doc with reviewers status (#11399)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> <code>Fix: Support boundary spread elements in sort-keys (#11158)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> <code>New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes #7145) (#11243)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> <code>Fix: comma-spacing ignore comma before closing paren (fixes #11295) (#11374)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> <code>Docs: fix space-before-blocks correct code for "classes": "never" (#11391)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> <code>Docs: fix grammar in object-curly-spacing docs (#11389)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> <code>Docs: fix grammar in “those who says” (#11390)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> <code>Docs: Add note about support for object spread (fixes #11136) (#11395)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> <code>Docs: Update README team and sponsors</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> <code>Update: Behavior of --init (fixes #11105) (#11332)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> <code>Docs: Update README team and sponsors</code></li> </ul> There are 51 commits in total. See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/faf3c4eda0d27323630d0bc103a99dd0ecffe842...af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b">full diff</a> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.7.0` to `5.14.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v5.14.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> Fix: adds conditional for separateRequires in one-var (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310933694" data-permission-text="Issue title is private" data-url="eslint/eslint#10179" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10179/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10179">#10179</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="369993599" data-permission-text="Issue title is private" data-url="eslint/eslint#10980" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10980/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10980">#10980</a>) (Scott Stern)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> Upgrade: espree@5.0.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410918526" data-permission-text="Issue title is private" data-url="eslint/eslint#11401" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11401/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11401">#11401</a>) (Ilya Volodin)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> Docs: Update governance doc with reviewers status (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410806033" data-permission-text="Issue title is private" data-url="eslint/eslint#11399" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11399/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11399">#11399</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> Fix: Support boundary spread elements in sort-keys (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387528357" data-permission-text="Issue title is private" data-url="eslint/eslint#11158" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11158/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11158">#11158</a>) (Jakub Rożek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="176681678" data-permission-text="Issue title is private" data-url="eslint/eslint#7145" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/7145/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/7145">#7145</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="396278013" data-permission-text="Issue title is private" data-url="eslint/eslint#11243" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11243/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11243">#11243</a>) (richie3366)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> Fix: comma-spacing ignore comma before closing paren (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401050405" data-permission-text="Issue title is private" data-url="eslint/eslint#11295" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11295/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11295">#11295</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408608672" data-permission-text="Issue title is private" data-url="eslint/eslint#11374" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11374/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11374">#11374</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> Docs: fix space-before-blocks correct code for "classes": "never" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410161351" data-permission-text="Issue title is private" data-url="eslint/eslint#11391" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11391/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11391">#11391</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> Docs: fix grammar in object-curly-spacing docs (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410128788" data-permission-text="Issue title is private" data-url="eslint/eslint#11389" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11389/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11389">#11389</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> Docs: fix grammar in “those who says” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410156839" data-permission-text="Issue title is private" data-url="eslint/eslint#11390" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11390/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11390">#11390</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> Docs: Add note about support for object spread (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="385126685" data-permission-text="Issue title is private" data-url="eslint/eslint#11136" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11136/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11136">#11136</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410444446" data-permission-text="Issue title is private" data-url="eslint/eslint#11395" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11395/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11395">#11395</a>) (Steven Thomas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> Update: Behavior of --init (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382337303" data-permission-text="Issue title is private" data-url="eslint/eslint#11105" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11105/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11105">#11105</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404422915" data-permission-text="Issue title is private" data-url="eslint/eslint#11332" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11332/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11332">#11332</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/550de1e611a1e9af873bcb18d74cf2056e8d2e1b"><code>550de1e</code></a> Update: use <code>default</code> keyword in JSON schema (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294113624" data-permission-text="Issue title is private" data-url="eslint/eslint#9929" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9929/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9929">#9929</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="400761608" data-permission-text="Issue title is private" data-url="eslint/eslint#11288" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11288/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11288">#11288</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/983c5201210d7a4ffab0b3d05ab9919c0754e5ca"><code>983c520</code></a> Update: Use 'readonly' and 'writable' for globals (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407305063" data-permission-text="Issue title is private" data-url="eslint/eslint#11359" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11359/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11359">#11359</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409412748" data-permission-text="Issue title is private" data-url="eslint/eslint#11384" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11384/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11384">#11384</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/f1d3a7ee7c82365989e219b1dae379f08f6dd526"><code>f1d3a7e</code></a> Upgrade: some deps (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408523961" data-permission-text="Issue title is private" data-url="eslint/eslint#11372" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11372/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11372">#11372</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408528993" data-permission-text="Issue title is private" data-url="eslint/eslint#11373" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11373/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11373">#11373</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3e0c4176eff085498b813f8ba1732d7ed6ee44f8"><code>3e0c417</code></a> Docs: Fix grammar in “there’s nothing prevent you” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409641227" data-permission-text="Issue title is private" data-url="eslint/eslint#11385" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11385/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11385">#11385</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/de988bc909b491366ad0cd9bc83f4d6de42d041a"><code>de988bc</code></a> Docs: Fix grammar: Spacing improve -> Spacing improves (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409657539" data-permission-text="Issue title is private" data-url="eslint/eslint#11386" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11386/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11386">#11386</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1309dfdebb5595460b79dcac20df6a1f109e7566"><code>1309dfd</code></a> Revert "Build: fix test failure on Node 11 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382010541" data-permission-text="Issue title is private" data-url="eslint/eslint#11100" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11100/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11100">#11100</a>)" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408638354" data-permission-text="Issue title is private" data-url="eslint/eslint#11375" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11375/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11375">#11375</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1e56897db3e254e0aef6d2fe3274157fc379c79e"><code>1e56897</code></a> Docs: “the function actually use”: use -> uses (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409158739" data-permission-text="Issue title is private" data-url="eslint/eslint#11380" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11380/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11380">#11380</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5a71bc95a7e961b1b1b77022645e0bd9cdd08dc0"><code>5a71bc9</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/82a58ce26b282fd80335b3ac4fc88f21266c3ba1"><code>82a58ce</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/546d355ace65631e27de859baea3ffcc50e0ad2c"><code>546d355</code></a> Docs: Update README with latest sponsors/team data (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408880022" data-permission-text="Issue title is private" data-url="eslint/eslint#11378" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11378/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11378">#11378</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c0df9febb7c7e045ababc10b88dbcbb3f28c724c"><code>c0df9fe</code></a> Docs: <code>...</code> is not an operator (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="395406535" data-permission-text="Issue title is private" data-url="eslint/eslint#11232" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11232/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11232">#11232</a>) (Felix Kling)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7ecfdefaeadb772f8b96ffe37c4a2c97fde0da16"><code>7ecfdef</code></a> Docs: update typescript parser (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408420749" data-permission-text="Issue title is private" data-url="eslint/eslint#11368" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11368/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11368">#11368</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408421449" data-permission-text="Issue title is private" data-url="eslint/eslint#11369" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11369/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11369">#11369</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3c90dd7e25cf97833deddb11cfbc107a5663ac08"><code>3c90dd7</code></a> Update: remove prefer-spread autofix (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404394299" data-permission-text="Issue title is private" data-url="eslint/eslint#11330" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11330/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11330">#11330</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408234262" data-permission-text="Issue title is private" data-url="eslint/eslint#11365" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11365/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11365">#11365</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5eb3121b82c1837da0c3021b7d9384bb30832e36"><code>5eb3121</code></a> Update: add fixer for <code>prefer-destructuring</code> (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="386647796" data-permission-text="Issue title is private" data-url="eslint/eslint#11151" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11151/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11151">#11151</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401382591" data-permission-text="Issue title is private" data-url="eslint/eslint#11301" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11301/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11301">#11301</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/173eb38cdb3e4673cba947521f27158828186d77"><code>173eb38</code></a> Docs: Clarify ecmaVersion doesn't imply globals (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="286511859" data-permission-text="Issue title is private" data-url="eslint/eslint#9812" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9812/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9812">#9812</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408046817" data-permission-text="Issue title is private" data-url="eslint/eslint#11364" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11364/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11364">#11364</a>) (Keith Maxwell)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/84ce72fdeba082b7b132e4ac6b714fb1a93831b7"><code>84ce72f</code></a> Fix: Remove extraneous linefeeds in <code>one-var</code> fixer (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="348084571" data-permission-text="Issue title is private" data-url="eslint/eslint#10741" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10741/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10741">#10741</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="368549184" data-permission-text="Issue title is private" data-url="eslint/eslint#10955" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10955/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10955">#10955</a>) (st-sloth)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/389362a06ac6601512b872d3e843c7371f2a1bcc"><code>389362a</code></a> Docs: clarify motivation for no-prototype-builtins (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407049599" data-permission-text="Issue title is private" data-url="eslint/eslint#11356" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11356/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11356">#11356</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/533d240b0811f663494cb213b06cc9e51e1ff2d0"><code>533d240</code></a> Update: no-shadow-restricted-names lets unassigned vars shadow undefined (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="405506188" data-permission-text="Issue title is private" data-url="eslint/eslint#11341" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11341/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11341">#11341</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d0e823aef196a6564c87a78b72c1ef980ce67af9"><code>d0e823a</code></a> Update: Make --init run js config files through linter (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294550736" data-permission-text="Issue title is private" data-url="eslint/eslint#9947" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9947/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9947">#9947</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404963393" data-permission-text="Issue title is private" data-url="eslint/eslint#11337" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11337/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11337">#11337</a>) (Brian Kurek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/92fc2f4f3faf8aeaae8a8e71db0de405404fb6c3"><code>92fc2f4</code></a> Fix: CircularJSON dependency warning (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="377112659" data-permission-text="Issue title is private" data-url="eslint/eslint#11052" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11052/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11052">#11052</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="402687981" data-permission-text="Issue title is private" data-url="eslint/eslint#11314" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11314/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11314">#11314</a>) (Terry)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4dd19a3c4c037adc860a65e96f2ba3eeccace1de"><code>4dd19a3</code></a> Docs: mention 'prefer-spread' in docs of 'no-useless-call' (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406005713" data-permission-text="Issue title is private" data-url="eslint/eslint#11348" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11348/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11348">#11348</a>) (Klaus Meinhardt)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4fd83d5ec47a6a7b81cd8801c3bd63d27ea1c7c4"><code>4fd83d5</code></a> Docs: fix a misleading example in one-var (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406350534" data-permission-text="Issue title is private" data-url="eslint/eslint#11350" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11350/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11350">#11350</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/9441ce77b7228f2c4562e158a10905afe11f31f2"><code>9441ce7</code></a> Chore: update incorrect tests to fix build failing (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406418834" data-permission-text="Issue title is private" data-url="eslint/eslint#11354" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11354/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11354">#11354</a>) (薛定谔的猫)</li> </ul> </details> <details> <summary>Commits</summary> The new version differs by 145 commits. <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b"><code>af9688b</code></a> <code>5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0ce3ac753017db813fb130d6563d524e29e20072"><code>0ce3ac7</code></a> <code>Build: changelog update for 5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> <code>Fix: adds conditional for separateRequires in one-var (fixes #10179) (#10980)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> <code>Upgrade: espree@5.0.1 (#11401)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> <code>Docs: Update governance doc with reviewers status (#11399)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> <code>Fix: Support boundary spread elements in sort-keys (#11158)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> <code>New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes #7145) (#11243)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> <code>Fix: comma-spacing ignore comma before closing paren (fixes #11295) (#11374)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> <code>Docs: fix space-before-blocks correct code for "classes": "never" (#11391)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> <code>Docs: fix grammar in object-curly-spacing docs (#11389)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> <code>Docs: fix grammar in “those who says” (#11390)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> <code>Docs: Add note about support for object spread (fixes #11136) (#11395)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> <code>Docs: Update README team and sponsors</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> <code>Update: Behavior of --init (fixes #11105) (#11332)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> <code>Docs: Update README team and sponsors</code></li> </ul> There are 145 commits in total. See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/77bb2071b4b9f78929bdf4b97a016fef106348e6...af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b">full diff</a> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 24, 2019

g-plane reviewed Jan 24, 2019

View reviewed changes

tests/lib/cli-engine.js Outdated Show resolved Hide resolved

Teamop force-pushed the fix-warning branch from b849e06 to 0ff5471 Compare January 24, 2019 16:39

Teamop commented Jan 24, 2019

View reviewed changes

tests/lib/cli-engine.js Outdated Show resolved Hide resolved

aladdin-add changed the title ~~Fix: CircularJSON dependency warning~~ Update: CircularJSON dependency warning Jan 26, 2019

aladdin-add changed the title ~~Update: CircularJSON dependency warning~~ Upgrade: CircularJSON dependency warning Jan 26, 2019

aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion upgrade This change is related to a dependency upgrade and removed triage An ESLint team member will look at this issue soon labels Jan 26, 2019

aladdin-add mentioned this pull request Jan 28, 2019

use checksum instead of mtime for caching to enable CI caching #11319

Closed

aladdin-add added the breaking This change is backwards-incompatible label Jan 29, 2019

not-an-aardvark suggested changes Jan 29, 2019

View reviewed changes

lxe mentioned this pull request Jan 31, 2019

CircularJSON dependency warning #11052

Closed

Teamop force-pushed the fix-warning branch from 0ff5471 to 047548d Compare February 3, 2019 11:02

Teamop force-pushed the fix-warning branch from 047548d to 4bc60a2 Compare February 4, 2019 11:20

Teamop force-pushed the fix-warning branch 2 times, most recently from f363256 to 2e48929 Compare February 5, 2019 01:39

Fix: CircularJSON dependency warning

dad7de6

Teamop force-pushed the fix-warning branch from 2e48929 to dad7de6 Compare February 5, 2019 02:18

platinumazure approved these changes Feb 5, 2019

View reviewed changes

not-an-aardvark approved these changes Feb 5, 2019

View reviewed changes

not-an-aardvark removed the breaking This change is backwards-incompatible label Feb 6, 2019

not-an-aardvark merged commit 92fc2f4 into eslint:master Feb 6, 2019

JustinBeckwith mentioned this pull request Feb 14, 2019

Avoid deprecated dependencies googleapis/nodejs-logging#277

Closed

ghost mentioned this pull request Jul 13, 2019

eslint needs update vuejs/vue-cli#4284

Closed

eslint-deprecated bot locked and limited conversation to collaborators Aug 6, 2019

eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade: CircularJSON dependency warning #11314

Upgrade: CircularJSON dependency warning #11314

Teamop commented Jan 24, 2019

jsf-clabot commented Jan 24, 2019 •

edited

g-plane left a comment

Teamop Jan 24, 2019

not-an-aardvark Jan 29, 2019

royriojas Feb 1, 2019

Teamop commented Jan 24, 2019

aladdin-add commented Jan 29, 2019

not-an-aardvark Jan 29, 2019

royriojas commented Feb 1, 2019

Teamop commented Feb 3, 2019 •

edited

royriojas commented Feb 4, 2019

Teamop commented Feb 4, 2019

royriojas commented Feb 4, 2019

Teamop commented Feb 5, 2019

g-plane commented Feb 5, 2019

Teamop commented Feb 5, 2019

g-plane commented Feb 5, 2019

Teamop commented Feb 5, 2019

platinumazure left a comment

royriojas commented Feb 5, 2019

platinumazure commented Feb 5, 2019

platinumazure commented Feb 5, 2019

royriojas commented Feb 5, 2019

Upgrade: CircularJSON dependency warning #11314

Upgrade: CircularJSON dependency warning #11314

Conversation

Teamop commented Jan 24, 2019

jsf-clabot commented Jan 24, 2019 • edited

g-plane left a comment

Choose a reason for hiding this comment

Teamop Jan 24, 2019

Choose a reason for hiding this comment

not-an-aardvark Jan 29, 2019

Choose a reason for hiding this comment

royriojas Feb 1, 2019

Choose a reason for hiding this comment

Teamop commented Jan 24, 2019

aladdin-add commented Jan 29, 2019

not-an-aardvark Jan 29, 2019

Choose a reason for hiding this comment

royriojas commented Feb 1, 2019

Teamop commented Feb 3, 2019 • edited

royriojas commented Feb 4, 2019

Teamop commented Feb 4, 2019

royriojas commented Feb 4, 2019

Teamop commented Feb 5, 2019

g-plane commented Feb 5, 2019

Teamop commented Feb 5, 2019

g-plane commented Feb 5, 2019

Teamop commented Feb 5, 2019

platinumazure left a comment

Choose a reason for hiding this comment

royriojas commented Feb 5, 2019

platinumazure commented Feb 5, 2019

platinumazure commented Feb 5, 2019

royriojas commented Feb 5, 2019

jsf-clabot commented Jan 24, 2019 •

edited

Teamop commented Feb 3, 2019 •

edited