Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecated dependencies #277

Closed
ofrobots opened this issue Oct 26, 2018 · 3 comments
Closed

Avoid deprecated dependencies #277

ofrobots opened this issue Oct 26, 2018 · 3 comments
Assignees
@JustinBeckwith
Labels
api: logging Issues related to the googleapis/nodejs-logging API. status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like.

Comments

@ofrobots
Copy link
Contributor

ofrobots commented Oct 26, 2018 •
edited

I see the following on a sample-tests build:

npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

Let's resolve these.
@JustinBeckwith
Copy link
Contributor

Yeah, text-encoding is being brought in by the latest version of sinon :/ I will look into the CIrcularJSON thing.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Oct 27, 2018
@JustinBeckwith JustinBeckwith self-assigned this Feb 12, 2019
@JustinBeckwith
Copy link
Contributor

So good news, bad news.

Good news - the circular-json issue has been fixed in eslint, and will be in the next release (which should be relatively soon.

Bad mews - the text-encoding issue is unresolved, and basically boils down to someone adopting ownership of the model. Sinon is pretty important, so I can't imagine us dropping that.

@JustinBeckwith
Copy link
Contributor

Both of these are fixed!

@google-cloud-label-sync google-cloud-label-sync bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
api: logging Issues related to the googleapis/nodejs-logging API. status: blocked Resolving the issue is dependent on other work. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ofrobots @JustinBeckwith