New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace inquirer library in eslint 5a3 #10404
Comments
I'm not opposed, but I'd like to see what other team members think. I'd be interested in seeing a PR with how it would look, but I also don't want to ask you to do work that we might just decide not to merge. I do think it could help, though (but either way is fine). |
Looking at this comment, could we also address this in the upstream repo by ensuring they don't put many unnecessary files in their published package? Not sure how feasible that is. |
ESLint is running on our/your development computer or CI server, not in browser. So, file size should not be cared. |
@g-plane We are trying to reduce the install size of create-react-app 2.0 which bundles eslint. |
I am also interested in this, because we are trying to embed eslint for SonarQube analyzer. Is it safe to remove inquirer from dependencies when eslint is not used interactively on command line but only executed as a standalone process? |
I'm also not opposed to this change. However, it has to be thoroughly verified, since we have almost not tests covering CLI interactions. |
I actually implemented it for eslint and it was fairly straightforward. But eslint moved out of beta fairly quickly and I was told enquirer was getting a version bump (never happened), and I wasn't sure if create-react-app planned on switching as well. I wonder if it's possible to have a CLI package just for initiating new projects. |
Could the config initializer (the part that depends on inquirer) be moved to a secondary package? @bugzpodder mentionned an alternative to inquirer. I'm using prompts now in my other projects and I'm very happy with that too. |
Unfortunately, it looks like there wasn't enough interest from the team Thanks for contributing to ESLint and we appreciate your understanding. |
In eslint 5 alpha 3, we have upgraded the inquirer library to 5.x from 3.3.0. This doubled the install size from 19MB to 37MB because inquirer switched from rx-lite (rxjs 4 lite to rxjs 5/6) in the newer builds SBoudrias/Inquirer.js#614
Would people here be open to use a more lightweight alternative such as http://enquirer.io/?
The text was updated successfully, but these errors were encountered: