Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace inquirer library in eslint 5a3 #10404

Closed
bugzpodder opened this issue May 28, 2018 · 9 comments
Closed

replace inquirer library in eslint 5a3 #10404

bugzpodder opened this issue May 28, 2018 · 9 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion

Comments

@bugzpodder
Copy link

In eslint 5 alpha 3, we have upgraded the inquirer library to 5.x from 3.3.0. This doubled the install size from 19MB to 37MB because inquirer switched from rx-lite (rxjs 4 lite to rxjs 5/6) in the newer builds SBoudrias/Inquirer.js#614

Would people here be open to use a more lightweight alternative such as http://enquirer.io/?

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 28, 2018
@platinumazure platinumazure added core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 28, 2018
@platinumazure
Copy link
Member

I'm not opposed, but I'd like to see what other team members think.

I'd be interested in seeing a PR with how it would look, but I also don't want to ask you to do work that we might just decide not to merge. I do think it could help, though (but either way is fine).

@platinumazure
Copy link
Member

Looking at this comment, could we also address this in the upstream repo by ensuring they don't put many unnecessary files in their published package? Not sure how feasible that is.

@g-plane
Copy link
Member

g-plane commented May 29, 2018

ESLint is running on our/your development computer or CI server, not in browser. So, file size should not be cared.

@bugzpodder
Copy link
Author

@g-plane We are trying to reduce the install size of create-react-app 2.0 which bundles eslint.
facebook/create-react-app#3880

@saberduck
Copy link
Contributor

I am also interested in this, because we are trying to embed eslint for SonarQube analyzer. Is it safe to remove inquirer from dependencies when eslint is not used interactively on command line but only executed as a standalone process?

@ilyavolodin
Copy link
Member

I'm also not opposed to this change. However, it has to be thoroughly verified, since we have almost not tests covering CLI interactions.

@bugzpodder
Copy link
Author

I actually implemented it for eslint and it was fairly straightforward. But eslint moved out of beta fairly quickly and I was told enquirer was getting a version bump (never happened), and I wasn't sure if create-react-app planned on switching as well.

I wonder if it's possible to have a CLI package just for initiating new projects.

@millette
Copy link

millette commented Oct 27, 2018

Could the config initializer (the part that depends on inquirer) be moved to a secondary package?

@bugzpodder mentionned an alternative to inquirer. I'm using prompts now in my other projects and I'm very happy with that too.

@eslint-deprecated
Copy link

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

@eslint-deprecated eslint-deprecated bot added the auto closed The bot closed this issue label Dec 11, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 10, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion auto closed The bot closed this issue core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

No branches or pull requests

6 participants