Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install size bloat for inquirer@5 #682

Closed
bugzpodder opened this issue May 28, 2018 · 4 comments
Closed

install size bloat for inquirer@5 #682

bugzpodder opened this issue May 28, 2018 · 4 comments

Comments

@bugzpodder
Copy link

Since Inquirer upgraded from rxjs-lite v4 to rxjs V5/6, the install size quadrupled from 7MB to 25MB.
Part of the reason is because of the way rxjs bundles (ReactiveX/rxjs#3334) but even if we do not account for src/ it is is still a 17MB dependency.

inquirer@5 is used by create-react-app@2 and eslint@5 and we are trying to see if there is anyway to reduce the install size and still use this dependency.
facebook/create-react-app#3880
eslint/eslint#10404

@SBoudrias
Copy link
Owner

Anyone has a suggestion on how to reduce rxjs size? We made the choice to use rxjs a long time ago, but it's been causing file size issues for a long time now...

@imhoffd
Copy link
Contributor

imhoffd commented May 30, 2018

Wait for https://tc39.github.io/proposal-observable? 😂

On a more serious note, it'd be possible to do a massive refactor of Inquirer to have the "core" be event-based, and then have inquirerjs-reactive or something for those who wish to use the reactive interface. Just a lot of work.

This library is depended upon by Facebook, ESLint, Vue, Ionic, Yeoman, and likely many more big names. Could we all come together and help? I'd be happy to give more hours of my time. I can't promise anything related to sponsorship, though.

@frangio
Copy link

frangio commented Jan 20, 2020

Please reopen this issue.

@SBoudrias
Copy link
Owner

If anyone wants to help, there's an on-going effort to refactor the core without rxjs who's the very large dependency.

#685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants