New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 4 EOL is on April 30th, not April 1st #10041
Comments
@mysticatea mentioned wanting to get #9893 into 4.0.0, if we delay the pre-releases it would give us time for that. |
A few things to consider:
I think I'm slightly leaning towards doing the first prerelease on March 16th anyway, because that is still fairly close to the EOL date (3 release cycles, assuming we continue with a prerelease every two weeks). But I'm not opposed to moving the date back if we want to get more features into v4. |
I think we can safely delay a first pre-release by another two weeks. One thing that we should try to fix before first pre-release is versioning for rules index file for our website. When we were doing alphas/betas for version 3, I had to manually copy that file with every release, which was a bit annoying. |
Currently, we support all ES2018 syntactic features on espree, but not on core rules. I'm happy if the last 4.x version supports it on core rules, too. But I'm not sure if we can implement it on the last 4.x version without oversights and we don't backport bug fixes to older major versions. So... I'm OK with either way. |
I would love to get eslint-canary fully working and my ajv upgrade prepped before pre-releases, though I could see an argument for actually merging the ajv upgrade in a major release if we aren't sure it won't break someone. (Personally, I'm pretty confident the change won't break anyone but also would love to prove it via eslint-canary.) |
What would everyone think about doing the first prerelease on March 30th, and starting to merge breaking changes after this release cycle (i.e. next week)? This would probably allow us to fix #9893 in v4.x, although probably not #9856 since the TSC meeting today was cancelled. There are also some minor breaking change proposals that haven't been accepted yet, including the question of which Node versions to support specifically. (We know we're dropping support for Node 4 and 5, but there is some debate about whether we will explicitly support versions like Please 👍 this comment if you're in favor of doing the release on March 30th, or feel free to 👎/continue the discussion if you have concerns. |
In addition to my 👍, not meeting #9856 into 4.0 could be perceived as an advantage since there’s a slight chance it’s a breaking change - we’d get to avoid that question altogether. |
It looks like there is a consensus about doing the first prerelease on March 30th based on the 👍s on #10041 (comment), so I'll close this issue. |
I realized I made a mistake when reading the Node release schedule -- the EOL date for Node 4 is April 30th, not April 1st. (I had accidentally been looking at the "Maintenance LTS Start" column rather than the "End-of-life" column.)
In today's TSC meeting, we decided to start doing prereleases for ESLint v5 on March 16th, but that decision was dependent on the assumption that the EOL date was April 1st. We might want to reevaluate that decision based on the corrected EOL date.
I've added the "tsc agenda" label to this issue to make sure we discuss it by the next meeting, but I'm hoping we can make a decision sooner by discussing it on this issue, because if we do the first prerelease on March 16th, we will probably want to merge some breaking changes before March 15th (the date of the next meeting).
cc @eslint/eslint-tsc
The text was updated successfully, but these errors were encountered: