Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 4 EOL is on April 30th, not April 1st #10041

Closed
not-an-aardvark opened this issue Mar 1, 2018 · 8 comments
Closed

Node 4 EOL is on April 30th, not April 1st #10041

not-an-aardvark opened this issue Mar 1, 2018 · 8 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion infrastructure Relates to the tools used in the ESLint development process

Comments

@not-an-aardvark
Copy link
Member

I realized I made a mistake when reading the Node release schedule -- the EOL date for Node 4 is April 30th, not April 1st. (I had accidentally been looking at the "Maintenance LTS Start" column rather than the "End-of-life" column.)

In today's TSC meeting, we decided to start doing prereleases for ESLint v5 on March 16th, but that decision was dependent on the assumption that the EOL date was April 1st. We might want to reevaluate that decision based on the corrected EOL date.

I've added the "tsc agenda" label to this issue to make sure we discuss it by the next meeting, but I'm hoping we can make a decision sooner by discussing it on this issue, because if we do the first prerelease on March 16th, we will probably want to merge some breaking changes before March 15th (the date of the next meeting).

cc @eslint/eslint-tsc

@not-an-aardvark not-an-aardvark added infrastructure Relates to the tools used in the ESLint development process evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion tsc agenda This issue will be discussed by ESLint's TSC at the next meeting labels Mar 1, 2018
@btmills
Copy link
Member

btmills commented Mar 1, 2018

@mysticatea mentioned wanting to get #9893 into 4.0.0, if we delay the pre-releases it would give us time for that.

@not-an-aardvark
Copy link
Member Author

A few things to consider:

  • The release process for ESLint v4 lasted about 11 weeks between the first alpha and the first stable release. If v5 takes a similar amount of time, then the stable release will already be after April 30th anyway.
  • The breaking changes scheduled for v5 seem more stable than the ones from v4 (i.e. we aren't rewriting indent), so ostensibly the v5 release process might take less time than v4.
  • Doing a release later would give us more time to land features in v4.

I think I'm slightly leaning towards doing the first prerelease on March 16th anyway, because that is still fairly close to the EOL date (3 release cycles, assuming we continue with a prerelease every two weeks). But I'm not opposed to moving the date back if we want to get more features into v4.

@ilyavolodin
Copy link
Member

I think we can safely delay a first pre-release by another two weeks. One thing that we should try to fix before first pre-release is versioning for rules index file for our website. When we were doing alphas/betas for version 3, I had to manually copy that file with every release, which was a bit annoying.

@mysticatea
Copy link
Member

Currently, we support all ES2018 syntactic features on espree, but not on core rules. I'm happy if the last 4.x version supports it on core rules, too. But I'm not sure if we can implement it on the last 4.x version without oversights and we don't backport bug fixes to older major versions. So... I'm OK with either way.

@platinumazure
Copy link
Member

I would love to get eslint-canary fully working and my ajv upgrade prepped before pre-releases, though I could see an argument for actually merging the ajv upgrade in a major release if we aren't sure it won't break someone. (Personally, I'm pretty confident the change won't break anyone but also would love to prove it via eslint-canary.)

@not-an-aardvark
Copy link
Member Author

What would everyone think about doing the first prerelease on March 30th, and starting to merge breaking changes after this release cycle (i.e. next week)? This would probably allow us to fix #9893 in v4.x, although probably not #9856 since the TSC meeting today was cancelled.

There are also some minor breaking change proposals that haven't been accepted yet, including the question of which Node versions to support specifically. (We know we're dropping support for Node 4 and 5, but there is some debate about whether we will explicitly support versions like 7.x and 6.0.0.) We could make those changes in a second alpha release after they are discussed at the next TSC meeting.

Please 👍 this comment if you're in favor of doing the release on March 30th, or feel free to 👎/continue the discussion if you have concerns.

@btmills
Copy link
Member

btmills commented Mar 16, 2018

In addition to my 👍, not meeting #9856 into 4.0 could be perceived as an advantage since there’s a slight chance it’s a breaking change - we’d get to avoid that question altogether.

@not-an-aardvark
Copy link
Member Author

It looks like there is a consensus about doing the first prerelease on March 30th based on the 👍s on #10041 (comment), so I'll close this issue.

@not-an-aardvark not-an-aardvark removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Mar 20, 2018
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 17, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

No branches or pull requests

5 participants