chore: review comments

eslint · Dec 17, 2021 · efc84a7 · efc84a7
1 parent 4079fe1
commit efc84a7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/.github/ISSUE_TEMPLATE/NEW_SYNTAX.md b/.github/ISSUE_TEMPLATE/NEW_SYNTAX.md
@@ -32,12 +32,14 @@ assignees: ''
 
 Please check off all items that have already been completed. Be sure to paste the pull request URLs next to each item so we can verify the work as done.
 
-* [ ] Ecma262 update: <!-- paste PR URL for this syntax here -->
-* [ ] ESTree update: <!-- paste PR URL for this ESTree update here -->
-* [ ] Acorn update: <!-- paste PR URL for this syntax here -->
-* [ ] `eslint-visitor-keys` update: <!-- paste PR URL for this syntax here -->
-* [ ] `espree` update: <!-- paste PR URL for this syntax here -->
-* [ ] `eslint-scope` update: <!-- paste PR URL for this syntax here -->
-* [ ] `eslint` update: <!-- paste PR URL for this syntax here -->
+- [ ] Ecma262 update: <!-- paste PR URL for this syntax here -->
+- [ ] ESTree update: <!-- paste PR URL for this ESTree update here -->
+- [ ] Acorn update: <!-- paste PR URL for this syntax here -->
+- [ ] `eslint-visitor-keys` update: <!-- paste PR URL for this syntax here -->
+- [ ] `espree` update: <!-- paste PR URL for this syntax here -->
+- [ ] `eslint-scope` update: <!-- paste PR URL for this syntax here -->
+- [ ] `eslint` update: <!-- paste PR URL for this syntax here -->
 
 **Are you willing to submit a pull request to implement this syntax?**
+
+<!-- markdownlint-disable-file MD004 -->
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -6,7 +6,7 @@
 
 #### Prerequisites checklist
 
-* [ ] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/HEAD/CONTRIBUTING.md).
+- [ ] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/HEAD/CONTRIBUTING.md).
 
 #### What is the purpose of this pull request? (put an "X" next to an item)
 
@@ -43,3 +43,5 @@
 #### What changes did you make? (Give an overview)
 
 #### Is there anything you'd like reviewers to focus on?
+
+<!-- markdownlint-disable-file MD004 -->
diff --git a/Makefile.js b/Makefile.js
@@ -886,7 +886,7 @@ target.checkRuleFiles = function() {
             }
 
             // check for proper doc headers
-            if (!hasKnownHeaders(basename)) {
+            if (!hasKnownHeaders()) {
                 console.error("Unknown or misplaced header in the doc page of rule %s, allowed headers (and their order) are: '%s'", basename, knownHeaders.join("', '"));
                 errors++;
             }