add test for excepting square brackets for never scenario

eslint · Aug 10, 2019 · dcca713 · dcca713
1 parent 7c6e53e
commit dcca713
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/lib/rules/space-in-parens.js b/lib/rules/space-in-parens.js
@@ -64,8 +64,7 @@ module.exports = {
 
         /*
          * workaround to prevent empty paren false positives
-         * if we always enforce a space, excepting parentheses
-         * then we never allow spaces inside parentheses (including empty ones)
+         * if we never allow a space inside parentheses this should include empty parentheses too
          */
         if (ALWAYS && options.parenException) {
             options.empty = true;
@@ -208,10 +207,6 @@ module.exports = {
                 return !isCloserException(left);
             }
 
-            // if (left.type === "Identifier") {
-            //     return false;
-            // }
-
             if (left.type !== "Punctuator") {
                 return isCloserException(right);
             }

diff --git a/tests/lib/rules/space-in-parens.js b/tests/lib/rules/space-in-parens.js
@@ -277,12 +277,21 @@ ruleTester.run("space-in-parens", rule, {
             ]
         },
         {
-            code: "foo(bar( ))",
-            output: "foo( bar( ) )",
+            code: "foo(bar())",
+            output: "foo( bar() )",
             options: ["never", { exceptions: ["()"] }],
             errors: [
                 { message: MISSING_OPENING_SPACE_ERROR, line: 1, column: 4 },
-                { message: MISSING_CLOSING_SPACE_ERROR, line: 1, column: 11 }
+                { message: MISSING_CLOSING_SPACE_ERROR, line: 1, column: 10 }
+            ]
+        },
+        {
+            code: "foo([1,2], bar() )",
+            output: "foo( [1,2], bar())",
+            options: ["never", { exceptions: ["[]"] }],
+            errors: [
+                { message: MISSING_OPENING_SPACE_ERROR, line: 1, column: 4 },
+                { message: REJECTED_CLOSING_SPACE_ERROR, line: 1, column: 18 }
             ]
         },
         {