fix: function-paren-newline: crash on "new new Foo();"

eslint · May 9, 2022 · d42e865 · d42e865
1 parent 9b17d6f
commit d42e865
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/rules/function-paren-newline.js b/lib/rules/function-paren-newline.js
@@ -191,10 +191,11 @@ module.exports = {
         function getParenTokens(node) {
             switch (node.type) {
                 case "NewExpression":
-                    if (!node.arguments.length && !(
-                        astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) &&
+                    if (node.callee.type === "NewExpression" ||
+                        !node.arguments.length && !(
+                            astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) &&
                         astUtils.isClosingParenToken(sourceCode.getLastToken(node))
-                    )) {
+                        )) {
 
                         // If the NewExpression does not have parens (e.g. `new Foo`), return null.
                         return null;

diff --git a/tests/lib/rules/function-paren-newline.js b/tests/lib/rules/function-paren-newline.js
@@ -30,6 +30,7 @@ const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 6 } });
 ruleTester.run("function-paren-newline", rule, {
 
     valid: [
+        "new new Foo();",
 
         // multiline option (default)
         "function baz(foo, bar) {}",