Skip to content

Commit

Permalink
chore: Make fixture test assertions more explicit
Browse files Browse the repository at this point in the history 
I need to add another formatter to this directory that will shift all of
these results, so I'm making these assertions more explicit so it's
obvious why a seemingly-unrelated change will cause these to fail.
  • Loading branch information
@btmills
btmills committed Nov 21, 2021
1 parent 0b2f5e2 commit d08f1ec
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 10 deletions.
21 changes: 15 additions & 6 deletions tests/lib/cli-engine/cli-engine.js
View file
Expand Up @@ -1158,28 +1158,32 @@ describe("CLIEngine", () => {
configFile: getFixturePath("configurations", "semi-error.json")
});

const report = engine.executeOnFiles([getFixturePath("formatters")]);
const fixturePath = getFixturePath("formatters");
const report = engine.executeOnFiles([fixturePath]);

assert.strictEqual(report.results.length, 3);
assert.strictEqual(report.errorCount, 0);
assert.strictEqual(report.warningCount, 0);
assert.strictEqual(report.fixableErrorCount, 0);
assert.strictEqual(report.fixableWarningCount, 0);
assert.strictEqual(report.results[0].messages.length, 0);
assert.strictEqual(report.results[1].messages.length, 0);
assert.strictEqual(report.results[2].messages.length, 0);
assert.strictEqual(report.results.length, 3);
assert.strictEqual(path.relative(fixturePath, report.results[0].filePath), "broken.js");
assert.strictEqual(report.results[0].errorCount, 0);
assert.strictEqual(report.results[0].warningCount, 0);
assert.strictEqual(report.results[0].fixableErrorCount, 0);
assert.strictEqual(report.results[0].fixableWarningCount, 0);
assert.strictEqual(report.results[0].messages.length, 0);
assert.strictEqual(path.relative(fixturePath, report.results[1].filePath), "simple.js");
assert.strictEqual(report.results[1].errorCount, 0);
assert.strictEqual(report.results[1].warningCount, 0);
assert.strictEqual(report.results[1].fixableErrorCount, 0);
assert.strictEqual(report.results[1].fixableWarningCount, 0);
assert.strictEqual(report.results[1].messages.length, 0);
assert.strictEqual(path.relative(fixturePath, report.results[2].filePath), path.join("test", "simple.js"));
assert.strictEqual(report.results[2].errorCount, 0);
assert.strictEqual(report.results[2].warningCount, 0);
assert.strictEqual(report.results[2].fixableErrorCount, 0);
assert.strictEqual(report.results[2].fixableWarningCount, 0);
assert.strictEqual(report.results[2].messages.length, 0);
});


Expand All @@ -1190,20 +1194,25 @@ describe("CLIEngine", () => {
configFile: getFixturePath("configurations", "single-quotes-error.json")
});

const report = engine.executeOnFiles([getFixturePath("formatters")]);
const fixturePath = getFixturePath("formatters");
const report = engine.executeOnFiles([fixturePath]);

assert.strictEqual(report.errorCount, 6);
assert.strictEqual(report.warningCount, 0);
assert.strictEqual(report.fixableErrorCount, 6);
assert.strictEqual(report.fixableWarningCount, 0);
assert.strictEqual(report.results.length, 3);
assert.strictEqual(path.relative(fixturePath, report.results[0].filePath), "broken.js");
assert.strictEqual(report.results[0].errorCount, 0);
assert.strictEqual(report.results[0].warningCount, 0);
assert.strictEqual(report.results[0].fixableErrorCount, 0);
assert.strictEqual(report.results[0].fixableWarningCount, 0);
assert.strictEqual(path.relative(fixturePath, report.results[1].filePath), "simple.js");
assert.strictEqual(report.results[1].errorCount, 3);
assert.strictEqual(report.results[1].warningCount, 0);
assert.strictEqual(report.results[1].fixableErrorCount, 3);
assert.strictEqual(report.results[1].fixableWarningCount, 0);
assert.strictEqual(path.relative(fixturePath, report.results[2].filePath), path.join("test", "simple.js"));
assert.strictEqual(report.results[2].errorCount, 3);
assert.strictEqual(report.results[2].warningCount, 0);
assert.strictEqual(report.results[2].fixableErrorCount, 3);
Expand Down
12 changes: 8 additions & 4 deletions tests/lib/eslint/eslint.js
View file
Expand Up @@ -1210,24 +1210,28 @@ describe("ESLint", () => {
cwd: path.join(fixtureDir, ".."),
overrideConfigFile: getFixturePath("configurations", "semi-error.json")
});
const results = await eslint.lintFiles([getFixturePath("formatters")]);
const fixturePath = getFixturePath("formatters");
const results = await eslint.lintFiles([fixturePath]);

assert.strictEqual(results.length, 3);
assert.strictEqual(results[0].messages.length, 0);
assert.strictEqual(results[1].messages.length, 0);
assert.strictEqual(results[2].messages.length, 0);
assert.strictEqual(path.relative(fixturePath, results[0].filePath), "broken.js");
assert.strictEqual(results[0].errorCount, 0);
assert.strictEqual(results[0].warningCount, 0);
assert.strictEqual(results[0].fixableErrorCount, 0);
assert.strictEqual(results[0].fixableWarningCount, 0);
assert.strictEqual(results[0].messages.length, 0);
assert.strictEqual(path.relative(fixturePath, results[1].filePath), "simple.js");
assert.strictEqual(results[1].errorCount, 0);
assert.strictEqual(results[1].warningCount, 0);
assert.strictEqual(results[1].fixableErrorCount, 0);
assert.strictEqual(results[1].fixableWarningCount, 0);
assert.strictEqual(results[1].messages.length, 0);
assert.strictEqual(path.relative(fixturePath, results[2].filePath), path.join("test", "simple.js"));
assert.strictEqual(results[2].errorCount, 0);
assert.strictEqual(results[2].warningCount, 0);
assert.strictEqual(results[2].fixableErrorCount, 0);
assert.strictEqual(results[2].fixableWarningCount, 0);
assert.strictEqual(results[2].messages.length, 0);
});

it("should process when file is given by not specifying extensions", async () => {
Expand Down

0 comments on commit d08f1ec

Please sign in to comment.