Ensure latest config is present in config stack for plugin-missing er…

…rors
eslint · Feb 20, 2019 · c3c04ab · c3c04ab
1 parent ecfb5f5
commit c3c04ab
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/lib/config/config-file.js b/lib/config/config-file.js
@@ -475,7 +475,14 @@ function loadObject(configContext, { config: configObject, filePath, configFullN
 
     // ensure plugins are properly loaded first
     if (config.plugins) {
-        configContext.plugins.loadAll(config.plugins);
+        try {
+            configContext.plugins.loadAll(config.plugins);
+        } catch (pluginLoadErr) {
+            if (pluginLoadErr.messageTemplate === "plugin-missing") {
+                pluginLoadErr.messageData.configStack.push(filePath);
+            }
+            throw pluginLoadErr;
+        }
     }
 
     // include full path of parser if present

diff --git a/tests/lib/config/config-file.js b/tests/lib/config/config-file.js
@@ -160,7 +160,7 @@ describe("ConfigFile", () => {
             }, /Failed to load config "plugin:enable-nonexistent-parser\/baz" to extend from./);
         });
 
-        it("should throw an error with a message template when a plugin is not found", () => {
+        it("should throw an error with a message template when a plugin referenced for a plugin config is not found", () => {
             try {
                 ConfigFile.applyExtends({
                     extends: "plugin:nonexistent-plugin/baz",
@@ -179,6 +179,28 @@ describe("ConfigFile", () => {
             assert.fail("Expected to throw an error");
         });
 
+        it("should throw an error with a message template when a plugin in the plugins list is not found", () => {
+            try {
+                ConfigFile.loadObject(configContext, {
+                    config: {
+                        plugins: ["nonexistent-plugin"]
+                    },
+                    filePath: "/whatever",
+                    configFullName: "configName"
+                });
+            } catch (err) {
+                assert.strictEqual(err.messageTemplate, "plugin-missing");
+                assert.deepStrictEqual(err.messageData, {
+                    pluginName: "eslint-plugin-nonexistent-plugin",
+                    pluginRootPath: getFixturePath("."),
+                    configStack: ["/whatever"]
+                });
+
+                return;
+            }
+            assert.fail("Expected to throw an error");
+        });
+
         it("should apply extensions recursively when specified from package", () => {
             const config = ConfigFile.applyExtends({
                 extends: "recursive-dependent",