Chore: removes unnecessary assignment in loop

also reduces cyclomatic complexity with a slight reconfiguring of some conditions
eslint · May 29, 2019 · 978fcc5 · 978fcc5
1 parent d662b17
commit 978fcc5
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/lib/linter/node-event-generator.js b/lib/linter/node-event-generator.js
@@ -221,17 +221,23 @@ class NodeEventGenerator {
             const selector = parseSelector(rawSelector);
 
             if (selector.listenerTypes) {
-                selector.listenerTypes.forEach(nodeType => {
-                    const typeMap = selector.isExit ? this.exitSelectorsByNodeType : this.enterSelectorsByNodeType;
+                const typeMap = selector.isExit ? this.exitSelectorsByNodeType : this.enterSelectorsByNodeType;
 
+                selector.listenerTypes.forEach(nodeType => {
                     if (!typeMap.has(nodeType)) {
                         typeMap.set(nodeType, []);
                     }
                     typeMap.get(nodeType).push(selector);
                 });
-            } else {
-                (selector.isExit ? this.anyTypeExitSelectors : this.anyTypeEnterSelectors).push(selector);
+                return;
             }
+
+            if (selector.isExit) {
+                this.anyTypeExitSelectors.push(selector);
+                return;
+            }
+
+            this.anyTypeEnterSelectors.push(selector);
         });
 
         this.anyTypeEnterSelectors.sort(compareSpecificity);