Fix: --init with Vue.js failed (fixes #11970)

eslint · Jul 14, 2019 · 926f74e · 926f74e
1 parent 2a10856
commit 926f74e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 8 deletions.
diff --git a/lib/init/config-initializer.js b/lib/init/config-initializer.js
@@ -100,14 +100,21 @@ function getModulesList(config, installESLint) {
             modules[`eslint-plugin-${plugin}`] = "latest";
         }
     }
-    if (config.extends && config.extends.indexOf("eslint:") === -1) {
-        const moduleName = `eslint-config-${config.extends}`;
-
-        modules[moduleName] = "latest";
-        Object.assign(
-            modules,
-            getPeerDependencies(`${moduleName}@latest`)
-        );
+    if (config.extends) {
+        const extendList = Array.isArray(config.extends) ? config.extends : [config.extends];
+
+        for (const extend of extendList) {
+            if (extend.startsWith("eslint:") || extend.startsWith("plugin:")) {
+                continue;
+            }
+            const moduleName = `eslint-config-${extend}`;
+
+            modules[moduleName] = "latest";
+            Object.assign(
+                modules,
+                getPeerDependencies(`${moduleName}@latest`)
+            );
+        }
     }
 
     if (installESLint === false) {

diff --git a/tests/lib/init/config-initializer.js b/tests/lib/init/config-initializer.js
@@ -306,6 +306,17 @@ describe("configInitializer", () => {
                     });
                 });
             });
+
+            it("should support the standard style guide with Vue.js", () => {
+                const config = {
+                    plugins: ["vue"],
+                    extends: ["plugin:vue/essential", "standard"]
+                };
+                const modules = init.getModulesList(config);
+
+                assert.include(modules, "eslint-plugin-vue@latest");
+                assert.include(modules, "eslint-config-standard@latest");
+            });
         });
 
         describe("auto", () => {