Fix: no-octal should report NonOctalDecimalIntegerLiteral (fixes #11794…

…) (#11805) Examples: 08, 018, 08.1
eslint · Jun 8, 2019 · 87451f4 · 87451f4
1 parent e4ab053
commit 87451f4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/rules/no-octal.js b/lib/rules/no-octal.js
@@ -28,7 +28,7 @@ module.exports = {
         return {
 
             Literal(node) {
-                if (typeof node.value === "number" && /^0[0-7]/u.test(node.raw)) {
+                if (typeof node.value === "number" && /^0[0-9]/u.test(node.raw)) {
                     context.report({ node, message: "Octal literals should not be used." });
                 }
             }

diff --git a/tests/lib/rules/no-octal.js b/tests/lib/rules/no-octal.js
@@ -30,6 +30,14 @@ ruleTester.run("no-octal", rule, {
     invalid: [
         { code: "var a = 01234;", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
         { code: "a = 1 + 01234;", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
-        { code: "00", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] }
+        { code: "00", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "08", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "09.1", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "09e1", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "09.1e1", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "018", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "019.1", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "019e1", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] },
+        { code: "019.1e1", errors: [{ message: "Octal literals should not be used.", type: "Literal" }] }
     ]
 });