Skip to content

Commit

Permalink
Chore: enable eslint-plugin-jsdoc (refs #11146)
Browse files Browse the repository at this point in the history
  • Loading branch information
kaicataldo committed Sep 29, 2019
1 parent 29c12f1 commit 82a0db8
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/linter/code-path-analysis/debug-helpers.js
Expand Up @@ -21,7 +21,7 @@ const debug = require("debug")("eslint:code-path");
* @returns {string} Id of the segment.
*/
/* istanbul ignore next */
function getId(segment) { // eslint-disable-line require-jsdoc
function getId(segment) { // eslint-disable-line jsdoc/require-jsdoc
return segment.id + (segment.reachable ? "" : "!");
}

Expand Down
1 change: 1 addition & 0 deletions package.json
Expand Up @@ -96,6 +96,7 @@
"eslint-config-eslint": "file:packages/eslint-config-eslint",
"eslint-plugin-eslint-plugin": "^2.0.1",
"eslint-plugin-internal-rules": "file:tools/internal-rules",
"eslint-plugin-jsdoc": "^15.9.5",
"eslint-plugin-node": "^9.0.0",
"eslint-release": "^1.2.0",
"eslump": "^2.0.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/eslint-config-eslint/default.yml
@@ -1,6 +1,8 @@
extends:
- "eslint:recommended"
- "plugin:node/recommended"
plugins:
- "jsdoc"
rules:
array-bracket-spacing: "error"
array-callback-return: "error"
Expand Down Expand Up @@ -31,6 +33,7 @@ rules:
generator-star-spacing: "error"
guard-for-in: "error"
handle-callback-err: ["error", "err"]
jsdoc/require-jsdoc: "error"
key-spacing: ["error", { beforeColon: false, afterColon: true }]
keyword-spacing: "error"
lines-around-comment: ["error", {
Expand Down Expand Up @@ -154,7 +157,6 @@ rules:
quotes: ["error", "double", {avoidEscape: true}]
quote-props: ["error", "as-needed"]
radix: "error"
require-jsdoc: "error"
require-unicode-regexp: "error"
rest-spread-spacing: "error"
semi: "error"
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-eslint/package.json
Expand Up @@ -20,6 +20,7 @@
"homepage": "https://eslint.org",
"bugs": "https://github.com/eslint/eslint/issues/",
"peerDependencies": {
"eslint-plugin-jsdoc": "^15.9.5",
"eslint-plugin-node": "^9.0.0"
},
"keywords": [
Expand Down

0 comments on commit 82a0db8

Please sign in to comment.