Skip to content

Commit

Permalink
chore: not set default 5
Browse files Browse the repository at this point in the history
  • Loading branch information
aladdin-add committed Jun 20, 2021
1 parent 6cbab8a commit 7b757d9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 23 deletions.
4 changes: 0 additions & 4 deletions lib/linter/linter.js
Expand Up @@ -441,10 +441,6 @@ function normalizeEcmaVersion(parser, ecmaVersion) {

// RuleTester always wraps parser, parser.$parser is the original parser object
if ((parser.$parser || parser) === espree) {
if (ecmaVersion === void 0) {
return DEFAULT_ECMA_VERSION;
}

if (ecmaVersion === "latest") {
return espree.latestEcmaVersion;
}
Expand Down
13 changes: 0 additions & 13 deletions tests/lib/linter/linter.js
Expand Up @@ -3501,19 +3501,6 @@ var a = "test2";
assert.strictEqual(messages.length, 1);
});

it("the default ECMAScript version is 5", () => {
let ecmaVersion = null;
const config = { rules: { "ecma-version": 2 } };

linter.defineRule("ecma-version", context => ({
Program() {
ecmaVersion = context.parserOptions.ecmaVersion;
}
}));
linter.verify("", config);
assert.strictEqual(ecmaVersion, 5);
});

it("supports ECMAScript version 'latest'", () => {
const messages = linter.verify("let x = 5 ** 7;", {
parserOptions: { ecmaVersion: "latest" }
Expand Down
12 changes: 6 additions & 6 deletions tests/lib/rule-tester/rule-tester.js
Expand Up @@ -809,21 +809,21 @@ describe("RuleTester", () => {
invalid: [
{
code: "",
errors: [{ messageId: "ecmaVersionMessage", data: { type: "number", ecmaVersion: "5" } }]
errors: [{ messageId: "ecmaVersionMessage", data: { type: "undefined", ecmaVersion: "undefined" } }]
},
{
code: "",
errors: [{ messageId: "ecmaVersionMessage", data: { type: "number", ecmaVersion: "5" } }],
errors: [{ messageId: "ecmaVersionMessage", data: { type: "undefined", ecmaVersion: "undefined" } }],
parserOptions: {}
},
{
code: "<div/>",
errors: [{ messageId: "ecmaVersionMessage", data: { type: "number", ecmaVersion: "5" } }],
errors: [{ messageId: "ecmaVersionMessage", data: { type: "undefined", ecmaVersion: "undefined" } }],
parserOptions: { ecmaFeatures: { jsx: true } }
},
{
code: "",
errors: [{ messageId: "ecmaVersionMessage", data: { type: "number", ecmaVersion: "5" } }],
errors: [{ messageId: "ecmaVersionMessage", data: { type: "undefined", ecmaVersion: "undefined" } }],
parser: require.resolve("espree")
},
{
Expand All @@ -838,12 +838,12 @@ describe("RuleTester", () => {
},
{
code: "",
errors: [{ messageId: "ecmaVersionMessage", data: { type: "number", ecmaVersion: "5" } }],
errors: [{ messageId: "ecmaVersionMessage", data: { type: "undefined", ecmaVersion: "undefined" } }],
env: { browser: true }
},
{
code: "",
errors: [{ messageId: "ecmaVersionMessage", data: { type: "number", ecmaVersion: "5" } }],
errors: [{ messageId: "ecmaVersionMessage", data: { type: "undefined", ecmaVersion: "undefined" } }],
env: { es6: false }
},
{
Expand Down

0 comments on commit 7b757d9

Please sign in to comment.