Update: add fixer for no-div-regex rule (fixes #11355) (#11744)

Adding fixer for no-div-regex-rule and use [=] instead of \= as suggestion to avoid conflicting with no-useless-escape error.
eslint · May 25, 2019 · 71716eb · 71716eb
1 parent 53f7f4c
commit 71716eb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/docs/rules/no-div-regex.md b/docs/rules/no-div-regex.md
@@ -23,7 +23,7 @@ Examples of **correct** code for this rule:
 ```js
 /*eslint no-div-regex: "error"*/
 
-function bar() { return /\=foo/; }
+function bar() { return /[=]foo/; }
 ```
 
 ## Related Rules

diff --git a/lib/rules/no-div-regex.js b/lib/rules/no-div-regex.js
@@ -20,6 +20,8 @@ module.exports = {
             url: "https://eslint.org/docs/rules/no-div-regex"
         },
 
+        fixable: "code",
+
         schema: [],
 
         messages: {
@@ -36,7 +38,13 @@ module.exports = {
                 const token = sourceCode.getFirstToken(node);
 
                 if (token.type === "RegularExpression" && token.value[1] === "=") {
-                    context.report({ node, messageId: "unexpected" });
+                    context.report({
+                        node,
+                        messageId: "unexpected",
+                        fix(fixer) {
+                            return fixer.replaceTextRange([token.range[0] + 1, token.range[0] + 2], "[=]");
+                        }
+                    });
                 }
             }
         };

diff --git a/tests/lib/rules/no-div-regex.js b/tests/lib/rules/no-div-regex.js
@@ -24,6 +24,10 @@ ruleTester.run("no-div-regex", rule, {
         "var f = function() { return /\\=foo/; };"
     ],
     invalid: [
-        { code: "var f = function() { return /=foo/; };", errors: [{ messageId: "unexpected", type: "Literal" }] }
+        {
+            code: "var f = function() { return /=foo/; };",
+            output: "var f = function() { return /[=]foo/; };",
+            errors: [{ messageId: "unexpected", type: "Literal" }]
+        }
     ]
 });