Skip to content

Commit

Permalink
Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (#10022)
Browse files Browse the repository at this point in the history
The different version of "table" dependency is causing a conflict with eslint 4.18.1 that requires "ajv": "^5.3.0"
  • Loading branch information
MS-elug authored and not-an-aardvark committed Feb 28, 2018
1 parent 3c697de commit 6b71fd0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -69,7 +69,7 @@
"semver": "^5.3.0",
"strip-ansi": "^4.0.0",
"strip-json-comments": "~2.0.1",
"table": "^4.0.1",
"table": "4.0.2",
"text-table": "~0.2.0"
},
"devDependencies": {
Expand Down

5 comments on commit 6b71fd0

@mikermcneil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MS-elug Hmm, this shouldn't matter-- npm will automatically install both versions of ajv. Unless... is eslint doing manual exploration of its node_modules folder?

As it is currently, everyone using the latest version of eslint is seeing a deprecation warning when they install it. Switching to table@4.0.3 should definitely fix that

@mikermcneil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@platinumazure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9856 will resolve this when it's merged in. Please follow that PR for updates. Thanks!

@mikermcneil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@platinumazure thanks!

@fsmeier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is happening again, could it be? in 5.2.0 it is "table": "^4.0.3",

Please sign in to comment.