Skip to content

Commit

Permalink
fix faulty tests
Browse files Browse the repository at this point in the history
The original tests were expecting a space where they should have been 
rejecting one.

Remember to invert: "spaces are never an error except inside 
parentheses" OR "spaces are always an error when inside parentheses"
  • Loading branch information
Che Fisher committed Nov 24, 2018
1 parent a675c89 commit 555b4df
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions tests/lib/rules/space-in-parens.js
Expand Up @@ -35,6 +35,7 @@ ruleTester.run("space-in-parens", rule, {
{ code: "var x = ( 1 + 2 ) * 3", options: ["always"] },
{ code: "var x = 'foo(bar)'", options: ["always"] },
{ code: "var x = 'bar( baz )'", options: ["always"] },
{ code: "var foo = (1 / (1 + 2))", options: ["never", { exceptions: ["()"] }] },
{ code: "var foo = `(bar)`;", options: ["always"], parserOptions: { ecmaVersion: 6 } },
{ code: "var foo = `(bar ${baz})`;", options: ["always"], parserOptions: { ecmaVersion: 6 } },
{ code: "var foo = `(bar ${( 1 + 2 )})`;", options: ["always"], parserOptions: { ecmaVersion: 6 } },
Expand Down Expand Up @@ -84,7 +85,7 @@ ruleTester.run("space-in-parens", rule, {
{ code: "foo( [ 1, 2 ], 1)", options: ["never", { exceptions: ["[]"] }] },
{ code: "foo( [\n1,\n2\n] )", options: ["never", { exceptions: ["[]"] }] },

{ code: "foo(( 1 + 2 ))", options: ["always", { exceptions: ["()"] }] },
{ code: "foo((1 + 2))", options: ["always", { exceptions: ["()"] }] },
{ code: "foo( ( 1 + 2 ) )", options: ["always", { exceptions: ["{}"] }] },
{ code: "foo( 1 / ( 1 + 2 ))", options: ["always", { exceptions: ["()"] }] },
{ code: "foo(( 1 + 2 ) / 1 )", options: ["always", { exceptions: ["()"] }] },
Expand Down Expand Up @@ -363,13 +364,13 @@ ruleTester.run("space-in-parens", rule, {
},
{
code: "( (1 + 2))",
output: "( (1 + 2) )",
output: "((1 + 2))",
options: ["never", { exceptions: ["()"] }],
errors: [MISSING_SPACE_ERROR]
errors: [REJECTED_SPACE_ERROR]
},
{
code: "(( 1 + 2 ) )",
output: "(( 1 + 2 ))",
code: "(foo() )",
output: "(foo())",
options: ["always", { exceptions: ["()"] }],
errors: [REJECTED_SPACE_ERROR]
},
Expand All @@ -386,10 +387,10 @@ ruleTester.run("space-in-parens", rule, {
errors: [REJECTED_SPACE_ERROR]
},
{
code: "var result = (1 / (1 + 2)) + 3",
output: "var result = (1 / (1 + 2) ) + 3",
code: "var result = ( 1 / (1 + 2) ) + 3",
output: "var result = (1 / (1 + 2)) + 3",
options: ["never", { exceptions: ["()"] }],
errors: [MISSING_SPACE_ERROR]
errors: [REJECTED_SPACE_ERROR, REJECTED_SPACE_ERROR]
},
{
code: "var result = ( 1 / ( 1 + 2)) + 3",
Expand Down

0 comments on commit 555b4df

Please sign in to comment.