Skip to content

Commit

Permalink
Chore: Fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@j-f1
j-f1 committed Jan 7, 2018
1 parent a996d8e commit 4d772d8
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 21 deletions.
2 changes: 1 addition & 1 deletion lib/rules/dot-notation.js
View file
Expand Up @@ -44,7 +44,7 @@ module.exports = {
fixable: "code",

messages: {
useDot: "[\"{{key}}\"] is better written in dot notation.",
useDot: "[{{key}}] is better written in dot notation.",
useBrackets: ".{{key}} is a syntax error."
}
},
Expand Down
8 changes: 4 additions & 4 deletions tests/lib/rules/array-bracket-newline.js
View file
Expand Up @@ -505,7 +505,7 @@ ruleTester.run("array-bracket-newline", rule, {
options: ["consistent"],
errors: [
{
message: ERR_BREAK_BEFORE,
messageId: "close",
type: "ArrayExpression",
line: 2,
column: 2,
Expand All @@ -520,7 +520,7 @@ ruleTester.run("array-bracket-newline", rule, {
options: ["consistent"],
errors: [
{
message: ERR_NO_BREAK_BEFORE,
messageId: "noClose",
type: "ArrayExpression",
line: 2,
column: 1,
Expand Down Expand Up @@ -1434,7 +1434,7 @@ ruleTester.run("array-bracket-newline", rule, {
parserOptions: { ecmaVersion: 6 },
errors: [
{
message: ERR_BREAK_BEFORE,
messageId: "close",
type: "ArrayPattern",
line: 2,
column: 2,
Expand All @@ -1450,7 +1450,7 @@ ruleTester.run("array-bracket-newline", rule, {
parserOptions: { ecmaVersion: 6 },
errors: [
{
message: ERR_NO_BREAK_BEFORE,
messageId: "noClose",
type: "ArrayPattern",
line: 2,
column: 1,
Expand Down
42 changes: 26 additions & 16 deletions tests/lib/rules/dot-notation.js
View file
Expand Up @@ -18,6 +18,16 @@ const rule = require("../../../lib/rules/dot-notation"),

const ruleTester = new RuleTester();

/**
* Quote a string in "double quotes" because it’s painful
* with a double-quoted string literal
* @param {string} str The string to quote
* @returns {string} `"${str}"`
*/
function q(str) {
return `"${str}"`;
}

ruleTester.run("dot-notation", rule, {
valid: [
"a.b;",
Expand Down Expand Up @@ -59,13 +69,13 @@ ruleTester.run("dot-notation", rule, {
{
code: "a['true'];",
output: "a.true;",
errors: [{ messageId: "useDot", data: { key: "true" } }]
errors: [{ messageId: "useDot", data: { key: q("true") } }]
},
{
code: "a[`time`];",
output: "a.time;",
parserOptions: { ecmaVersion: 6 },
errors: [{ message: "[`time`] is better written in dot notation." }]
errors: [{ messageId: "useDot", data: { key: "`time`" } }]
},
{
code: "a[null];",
Expand All @@ -75,24 +85,24 @@ ruleTester.run("dot-notation", rule, {
{
code: "a['b'];",
output: "a.b;",
errors: [{ messageId: "useDot", data: { key: "b" } }]
errors: [{ messageId: "useDot", data: { key: q("b") } }]
},
{
code: "a.b['c'];",
output: "a.b.c;",
errors: [{ messageId: "useDot", data: { key: "c" } }]
errors: [{ messageId: "useDot", data: { key: q("c") } }]
},
{
code: "a['_dangle'];",
output: "a._dangle;",
options: [{ allowPattern: "^[a-z]+(_[a-z]+)+$" }],
errors: [{ messageId: "useDot", data: { key: "_dangle" } }]
errors: [{ messageId: "useDot", data: { key: q("_dangle") } }]
},
{
code: "a['SHOUT_CASE'];",
output: "a.SHOUT_CASE;",
options: [{ allowPattern: "^[a-z]+(_[a-z]+)+$" }],
errors: [{ messageId: "useDot", data: { key: "SHOUT_CASE" } }]
errors: [{ messageId: "useDot", data: { key: q("SHOUT_CASE") } }]
},
{
code:
Expand All @@ -103,7 +113,7 @@ ruleTester.run("dot-notation", rule, {
" .SHOUT_CASE;",
errors: [{
messageId: "useDot",
data: { key: "SHOUT_CASE" },
data: { key: q("SHOUT_CASE") },
line: 2,
column: 4
}]
Expand All @@ -124,13 +134,13 @@ ruleTester.run("dot-notation", rule, {
errors: [
{
messageId: "useDot",
data: { key: "catch" },
data: { key: q("catch") },
line: 3,
column: 6
},
{
messageId: "useDot",
data: { key: "catch" },
data: { key: q("catch") },
line: 5,
column: 6
}
Expand All @@ -149,17 +159,17 @@ ruleTester.run("dot-notation", rule, {
{
code: "foo[ /* comment */ 'bar' ]",
output: null, // Not fixed due to comment
errors: [{ messageId: "useDot", data: { key: "bar" } }]
errors: [{ messageId: "useDot", data: { key: q("bar") } }]
},
{
code: "foo[ 'bar' /* comment */ ]",
output: null, // Not fixed due to comment
errors: [{ messageId: "useDot", data: { key: "bar" } }]
errors: [{ messageId: "useDot", data: { key: q("bar") } }]
},
{
code: "foo[ 'bar' ];",
output: "foo.bar;",
errors: [{ messageId: "useDot", data: { key: "bar" } }]
errors: [{ messageId: "useDot", data: { key: q("bar") } }]
},
{
code: "foo. /* comment */ while",
Expand All @@ -170,7 +180,7 @@ ruleTester.run("dot-notation", rule, {
{
code: "foo[('bar')]",
output: "foo.bar",
errors: [{ messageId: "useDot", data: { key: "bar" } }]
errors: [{ messageId: "useDot", data: { key: q("bar") } }]
},
{
code: "foo[(null)]",
Expand All @@ -180,17 +190,17 @@ ruleTester.run("dot-notation", rule, {
{
code: "(foo)['bar']",
output: "(foo).bar",
errors: [{ messageId: "useDot", data: { key: "bar" } }]
errors: [{ messageId: "useDot", data: { key: q("bar") } }]
},
{
code: "1['toString']",
output: "1 .toString",
errors: [{ messageId: "useDot", data: { key: "toString" } }]
errors: [{ messageId: "useDot", data: { key: q("toString") } }]
},
{
code: "foo['bar']instanceof baz",
output: "foo.bar instanceof baz",
errors: [{ messageId: "useDot", data: { key: "bar" } }]
errors: [{ messageId: "useDot", data: { key: q("bar") } }]
},
{
code: "let.if()",
Expand Down

0 comments on commit 4d772d8

Please sign in to comment.