Update spacing rules to be of type style

eslint · Oct 5, 2018 · 4453327 · 4453327
1 parent 8f600a7
commit 4453327
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/lib/rules/rest-spread-spacing.js b/lib/rules/rest-spread-spacing.js
@@ -11,7 +11,7 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
+        type: "style",
 
         docs: {
             description: "enforce spacing between rest and spread operators and their expressions",

diff --git a/lib/rules/yield-star-spacing.js b/lib/rules/yield-star-spacing.js
@@ -11,7 +11,7 @@
 
 module.exports = {
     meta: {
-        type: "suggestion",
+        type: "style",
 
         docs: {
             description: "require or disallow spacing around the `*` in `yield*` expressions",

diff --git a/tools/rule-types.json b/tools/rule-types.json
@@ -236,7 +236,7 @@
     "require-jsdoc": "style",
     "require-unicode-regexp": "suggestion",
     "require-yield": "suggestion",
-    "rest-spread-spacing": "suggestion",
+    "rest-spread-spacing": "style",
     "semi": "style",
     "semi-spacing": "style",
     "semi-style": "style",
@@ -261,6 +261,6 @@
     "vars-on-top": "suggestion",
     "wrap-iife": "suggestion",
     "wrap-regex": "style",
-    "yield-star-spacing": "suggestion",
+    "yield-star-spacing": "style",
     "yoda": "suggestion"
 }
diff --git a/tools/update-rule-types.js b/tools/update-rule-types.js
@@ -24,8 +24,13 @@ module.exports = (fileInfo, api) => {
 
         // gather important nodes from the rule
         const metaNode = p.node.properties.find(node => node.key.name === "meta");
-        const typeNode = metaNode.value.properties ? metaNode.value.properties.find(node => node.key.name === "type") : null;
 
+        // if there's no properties, just exit
+        if (!metaNode.value.properties) {
+            return; 
+        }
+
+        const typeNode = metaNode.value.properties.find(node => node.key.name === "type");
         const docsNode = metaNode.value.properties.find(node => node.key.name === "docs");
         const categoryNode = docsNode.value.properties.find(node => node.key.name === "category").value;