Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Created the JSLint XML formatter. Because JSLint XML has the `evidence` attribute which contains the erroring source code, I've added the source of the erroring node to the message objects created in `api.report` in `lib/eslint.js`. Fixes #15
- Loading branch information
Showing
3 changed files
with
164 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* @fileoverview JSLint XML reporter | ||
* @author Ian Christian Myers | ||
*/ | ||
|
||
//------------------------------------------------------------------------------ | ||
// Public Interface | ||
//------------------------------------------------------------------------------ | ||
|
||
module.exports = function(results) { | ||
|
||
var output = ""; | ||
|
||
output += "<?xml version=\"1.0\" encoding=\"utf-8\"?>"; | ||
output += "<jslint>"; | ||
|
||
results.forEach(function(result) { | ||
var messages = result.messages; | ||
|
||
output += "<file name=\"" + result.filePath + "\">"; | ||
|
||
messages.forEach(function(message) { | ||
output += "<issue line=\"" + message.line + "\" " + | ||
"char=\"" + message.column + "\" " + | ||
"evidence=\"" + message.source + "\" " + | ||
"reason=\"" + message.message + "\" />"; | ||
}); | ||
|
||
output += "</file>"; | ||
|
||
}); | ||
|
||
output += "</jslint>"; | ||
|
||
return output; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,126 @@ | ||
/** | ||
* @fileoverview Tests for JSLint XML reporter. | ||
* @author Ian Christian Myers | ||
*/ | ||
|
||
//------------------------------------------------------------------------------ | ||
// Requirements | ||
//------------------------------------------------------------------------------ | ||
|
||
var vows = require("vows"), | ||
assert = require("assert"), | ||
formatter = require("../../../lib/formatters/jslint-xml"); | ||
|
||
//------------------------------------------------------------------------------ | ||
// Tests | ||
//------------------------------------------------------------------------------ | ||
|
||
vows.describe("formatter:jslint-xml").addBatch({ | ||
|
||
"when passed a single message": { | ||
|
||
topic: [{ | ||
filePath: "foo.js", | ||
messages: [{ | ||
message: "Unexpected foo.", | ||
line: 5, | ||
column: 10, | ||
ruleId: "foo", | ||
source: "foo" | ||
}] | ||
}], | ||
|
||
"should return a string in JSLint XML format with 1 issue in 1 file": function(topic) { | ||
var config = { | ||
rules: { foo: 2 } | ||
}; | ||
|
||
var result = formatter(topic, config); | ||
assert.equal("<?xml version=\"1.0\" encoding=\"utf-8\"?><jslint><file name=\"foo.js\"><issue line=\"5\" char=\"10\" evidence=\"foo\" reason=\"Unexpected foo.\" /></file></jslint>", result); | ||
} | ||
|
||
}, | ||
|
||
"when passed a fatal error message": { | ||
|
||
topic: [{ | ||
filePath: "foo.js", | ||
messages: [{ | ||
fatal: true, | ||
message: "Unexpected foo.", | ||
line: 5, | ||
column: 10, | ||
ruleId: "foo", | ||
source: "foo" | ||
}] | ||
}], | ||
|
||
"should return a string in JSLint XML format with 1 issue in 1 file": function(topic) { | ||
var config = {}; // doesn't matter what's in the config for this test | ||
|
||
var result = formatter(topic, config); | ||
assert.equal("<?xml version=\"1.0\" encoding=\"utf-8\"?><jslint><file name=\"foo.js\"><issue line=\"5\" char=\"10\" evidence=\"foo\" reason=\"Unexpected foo.\" /></file></jslint>", result); | ||
} | ||
}, | ||
|
||
"when passed multiple messages": { | ||
topic: [{ | ||
filePath: "foo.js", | ||
messages: [{ | ||
message: "Unexpected foo.", | ||
line: 5, | ||
column: 10, | ||
ruleId: "foo", | ||
source: "foo" | ||
}, { | ||
message: "Unexpected bar.", | ||
line: 6, | ||
column: 11, | ||
ruleId: "bar", | ||
source: "bar" | ||
}] | ||
}], | ||
|
||
"should return a string in JSLint XML format with 2 issues in 1 file": function(topic) { | ||
var config = { | ||
rules: { foo: 2, bar: 1 } | ||
}; | ||
|
||
var result = formatter(topic, config); | ||
assert.equal("<?xml version=\"1.0\" encoding=\"utf-8\"?><jslint><file name=\"foo.js\"><issue line=\"5\" char=\"10\" evidence=\"foo\" reason=\"Unexpected foo.\" /><issue line=\"6\" char=\"11\" evidence=\"bar\" reason=\"Unexpected bar.\" /></file></jslint>", result); | ||
} | ||
|
||
}, | ||
|
||
"when passed multiple files with 1 message each": { | ||
topic: [{ | ||
filePath: "foo.js", | ||
messages: [{ | ||
message: "Unexpected foo.", | ||
line: 5, | ||
column: 10, | ||
ruleId: "foo", | ||
source: "foo" | ||
}] | ||
}, { | ||
filePath: "bar.js", | ||
messages: [{ | ||
message: "Unexpected bar.", | ||
line: 6, | ||
column: 11, | ||
ruleId: "bar", | ||
source: "bar" | ||
}] | ||
}], | ||
|
||
"should return a string in JSLint XML format with 2 issues in 2 files": function(topic) { | ||
var config = { | ||
rules: { foo: 2, bar: 1 } | ||
}; | ||
|
||
var result = formatter(topic, config); | ||
assert.equal("<?xml version=\"1.0\" encoding=\"utf-8\"?><jslint><file name=\"foo.js\"><issue line=\"5\" char=\"10\" evidence=\"foo\" reason=\"Unexpected foo.\" /></file><file name=\"bar.js\"><issue line=\"6\" char=\"11\" evidence=\"bar\" reason=\"Unexpected bar.\" /></file></jslint>", result); | ||
} | ||
} | ||
|
||
}).export(module); |