Fix: Removing curly quotes in no-eq-null report message (#9852)

eslint · Jan 20, 2018 · 13bcf3c · 13bcf3c
1 parent b96fb31
commit 13bcf3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/rules/no-eq-null.js b/lib/rules/no-eq-null.js
@@ -31,7 +31,7 @@ module.exports = {
 
                 if (node.right.type === "Literal" && node.right.raw === "null" && badOperator ||
                         node.left.type === "Literal" && node.left.raw === "null" && badOperator) {
-                    context.report({ node, message: "Use ‘===’ to compare with ‘null’." });
+                    context.report({ node, message: "Use '===' to compare with null." });
                 }
             }
         };

diff --git a/tests/lib/rules/no-eq-null.js b/tests/lib/rules/no-eq-null.js
@@ -18,14 +18,16 @@ const rule = require("../../../lib/rules/no-eq-null"),
 
 const ruleTester = new RuleTester();
 
+const MESSAGE = "Use '===' to compare with null.";
+
 ruleTester.run("no-eq-null", rule, {
     valid: [
         "if (x === null) { }",
         "if (null === f()) { }"
     ],
     invalid: [
-        { code: "if (x == null) { }", errors: [{ message: "Use ‘===’ to compare with ‘null’.", type: "BinaryExpression" }] },
-        { code: "if (x != null) { }", errors: [{ message: "Use ‘===’ to compare with ‘null’.", type: "BinaryExpression" }] },
-        { code: "do {} while (null == x)", errors: [{ message: "Use ‘===’ to compare with ‘null’.", type: "BinaryExpression" }] }
+        { code: "if (x == null) { }", errors: [{ message: MESSAGE, type: "BinaryExpression" }] },
+        { code: "if (x != null) { }", errors: [{ message: MESSAGE, type: "BinaryExpression" }] },
+        { code: "do {} while (null == x)", errors: [{ message: MESSAGE, type: "BinaryExpression" }] }
     ]
 });