chore: switch to eslint v9, eslint-config-eslint v10 #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for new-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aladdin-add
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Switches to using eslint v9 and eslint-config-eslint v10 to lint this project.
What changes did you make? (Give an overview)
package.jsonto use ESLint v9 and eslint-config-eslint v10. Also bumped eslint plugins to the latest versions."overrides": { "eslint": "^9.2.0" }topackage.jsonto makenpm installwork becauseeslint-plugin-jsx-a11y,eslint-plugin-reactandeslint-plugin-react-hooksdon't have eslint v9 in range in peer dependencies.eslint.config.jsto use eslint-config-eslint 'sbaseconfig for playground files, so that there's no need anymore to disableeslint-plugin-nrules. The previously usedcjsconfig is for Node.js CommonJS projects, which Playground is not.@eslint/compatoneslint-plugin-jsx-a11y,eslint-plugin-reactandeslint-plugin-react-hooksas neither of these plugins officially supports eslint v9 yet (although onlyeslint-plugin-reactthrows errors likecontext.getScopeis not a function).Related Issues
No.
Is there anything you'd like reviewers to focus on?