Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sourceType:commonjs support #81

Merged
merged 2 commits into from Nov 21, 2021
Merged

feat: Add sourceType:commonjs support #81

merged 2 commits into from Nov 21, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Nov 16, 2021

Adds sourceType:commonjs support so that passing this option is equivalent to setting nodejsScope: true.

Related: eslint/espree#520

@nzakas nzakas mentioned this pull request Nov 16, 2021
Merged
mdjermanovic
mdjermanovic approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just a couple of comments that would be nice to update with the new value:

eslint-scope/lib/index.js

Line 69 in 82a7e6d

sourceType: "script", // one of ['script', 'module']

eslint-scope/lib/index.js

Line 125 in 82a7e6d

* @param {string} [providedOptions.sourceType='script'] the source type of the script. one of 'script' and 'module'

@nzakas
Copy link
Member Author

nzakas commented Nov 19, 2021

Oops, looked like I made the changes and forgot to add to the PR. Added now. Nice catch.

@btmills btmills merged commit d756f1e into main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btmills btmills btmills approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nzakas @btmills @mdjermanovic