Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: standardize npm script names #105

Merged
merged 2 commits into from Aug 2, 2023
Merged

chore: standardize npm script names #105

merged 2 commits into from Aug 2, 2023

Conversation

snitin315
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Refers eslint/eslint#14827

What changes did you make? (Give an overview)

This updates the names of the scripts in package.json to be consistent with the new standard.

Is there anything you'd like reviewers to focus on?

We may need to update the release related scripts on Jenkins before merging this PR.

package.json Outdated Show resolved Hide resolved
@snitin315 snitin315 requested a review from nzakas August 2, 2023 00:55
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @nzakas to verify.

I can update the Jenkins script after we merge this. For projects for which we are using release-please, Jenkins is just a backup.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 115ded3 into main Aug 2, 2023
12 checks passed
@nzakas nzakas deleted the update-npm-scripts branch August 2, 2023 14:53
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
@mdjermanovic
Copy link
Member

We may need to update the release related scripts on Jenkins before merging this PR.

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants