Base indent for multiple line breaks; npm #126
Conversation
Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps. In process of updating: 1. Get plugins tests to work with eslint 6 2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
In the process, add to the ignore file and explicitly exclude undesired
|
Btw, I didn't update And I'm not sure why the commit message is still failing despite my attempting to follow the eslint guidelines. |
|
Hi @brettz9, thanks for taking the initiative to do all of this! As-is, this pull request does too many different things, so let's split it up into a couple:
I'm less convinced of need for the
I'll keep this open for now to track the changes to fix #127 and modify |
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. and devDeps; istanbul -> nyc Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps. In process of updating: 1. Get plugins tests to work with eslint 6 2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
|
Btw, I see the processor API is already ready with eslint/eslint#11552 and the docs updated: https://eslint.org/docs/developer-guide/working-with-plugins . FWIW, in applying the new processor API, you may still find my work updating the deps/devDeps helpful as it took me some time to figure out, e.g., my not finding anywhere that |
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. and devDeps; istanbul -> nyc Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps. In process of updating: 1. Get plugins tests to work with eslint 6 2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. and devDeps; istanbul -> nyc Update object-assign, unified, remark-parse for deps and eslint-release, chai, mocha, eslint for devDeps. In process of updating: 1. Get plugins tests to work with eslint 6 2. In whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
Thanks so much for the reference! I appreciate having that available when I get to it. |
|
If you're willing to pull just the |
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. Update object-assign, unified, remark-parse for deps. In process of updating, for whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. Update object-assign, unified, remark-parse for deps. In process of updating, for whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. Update object-assign, unified, remark-parse for deps. In process of updating, for whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. Update object-assign, unified, remark-parse for deps. In process of updating, for whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. Update unified, remark-parse for deps. In process of updating, for whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. Update unified, remark-parse for deps. In process of updating, for whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
…ps://github.com/eslint/rfcs/tree/master/designs/2018-processors-improvements / eslint/eslint#11552 Upgrade: Update deps. Update unified, remark-parse for deps. In process of updating, for whitespace processor test, add an extra line break for the expected since `remark-parse@7` started preserving them (see remarkjs/remark#351 )
remark-parse@7started preserving them (see [CommonMark] Leading/trailing newlines are stripped in the value of fenced codeblock remarkjs/remark#351 )Makefile.jsNote that the only dep./devDep. that had an upgrade but which I didn't upgrade was
eslint-plugin-node, aseslint-config-eslintis still tied to an older version thereof.Btw, the reason I changed to explicitly ignoring more files was so that the likes of my IDE linter wouldn't try to lint files which you hadn't excluded, even though your npm script wasn't targeted at them previously. I also figured it safer to lint all by default and just exclude the ones you don't want linted.