chore: Changes to support static frontmatter in docs #933
Conversation
✅ Deploy Preview for eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
docs/rules/array-bracket-newline.md
Outdated
(fixable) The `--fix` option on the [command line](../user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule. | ||
<!--FIXABLE--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text is generated by Makefile.js. If we remove it here, it will be lost.
https://deploy-preview-933--eslint.netlify.app/docs/rules/array-bracket-newline
(the same for recommended and suggestions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the goal is to generate this text during the website build, we should add to this repo some code that generates it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be generated by gensite in the ESLint repo. You already identified the bug there that caused this.
If we want to add (when there's a Step 2 in Makefile.js is actually not removing anything from the website. It looks like it expects a list of files, but gets a list of directories. |
Could have sworn I did that but maybe didn’t make it into the last commit. |
It looks like the website is now dependent on Makefile.js not removing old files (I tried fixing it but it introduced a bunch of errors due to files that live in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Updated website templates to us the static frontmatter in the docs files (eslint/eslint#15782).
Changes include:
doc.liquid
to show titles from frontmatter (fall back to older way for versioned URLs such as /docs/7.0.0)