Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Fix typos #798

Closed
wants to merge 1 commit into from
Closed

Fix typos #798

wants to merge 1 commit into from

Conversation

friederbluemle
Copy link

Just a couple of minor typo/capitalization fixes.

@jsf-clabot
Copy link

jsf-clabot commented Oct 1, 2020

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Oct 1, 2020
@eslint-deprecated
Copy link
Contributor

Hi @friederbluemle!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@netlify
Copy link

netlify bot commented Oct 1, 2020

Deploy preview for eslint ready!

Built with commit 3a79f3a

https://deploy-preview-798--eslint.netlify.app

@eslint-deprecated
Copy link
Contributor

Hi @friederbluemle!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

Read more about contributing to ESLint here

@eslint-deprecated
Copy link
Contributor

Hi @friederbluemle!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

@@ -123,7 +123,7 @@ If your project will not be following a consistent comma-spacing pattern, turn t

## Further Reading

* [Javascript](http://javascript.crockford.com/code.html)
* [JavaScript](http://javascript.crockford.com/code.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this change must be made in the main eslint/eslint repo because that’s the source of our docs. Making the change here will only update the live site and will disappear in the next release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up @nzakas 👍

eslint/eslint#13730

@nzakas
Copy link
Member

nzakas commented Oct 2, 2020

We also need you to sign our CLA before we can merge any contributions. You can do so here:

https://cla.js.foundation/eslint/website?pullRequest=798

@nzakas
Copy link
Member

nzakas commented Feb 18, 2021

Out of date, so closing.

@nzakas nzakas closed this Feb 18, 2021
@friederbluemle
Copy link
Author

Hi @nzakas - I just rebased my local branch, and one of the two changes is still applicable. Can you reopen please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants