Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Docs: updated blockquote css #566

Closed
wants to merge 5 commits into from

Conversation

AlokTakshak
Copy link
Contributor

No description provided.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label May 8, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert the CSS changes for now and see how things look with just the blockquote removal in the Markdown source. If we need to add a CSS change later, we can do so. Thanks!

@AlokTakshak
Copy link
Contributor Author

Let's revert the CSS changes for now and see how things look with just the blockquote removal in the Markdown source. If we need to add a CSS change later, we can do so. Thanks!

image

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like to have one more set of eyes on this.

@btmills
Copy link
Member

btmills commented Jun 7, 2019

@AlokTakshak apologies for not seeing this before, and thanks for the tag @platinumazure. When we do a release of ESLint, the build process regenerates the eslint.org site in this repository from documentation stored in eslint/eslint, which is the authoritative copy. Here’s this file over in the main repository: https://github.com/eslint/eslint/blob/master/docs/developer-guide/working-with-rules.md Can you open a pull request in the eslint/eslint repository with this change and tag me or request a review so I get a notification? That’ll keep your fix from being overwritten by the next release.

It looks like the blank lines before countOptions And rangeOptions were lost in this change. Those prevent Markdown from joining those lines onto the previous list item.

Thanks for your patience in getting this fixed!

@AlokTakshak
Copy link
Contributor Author

@btmills i tagged you in the other PR on eslint and here also i have updated the line space

@btmills
Copy link
Member

btmills commented Jun 10, 2019

This was fixed in eslint/eslint#11818, and it's now visible in the v6 prerelease docs! The fix will make its way into the main docs once v6.0.0 is released. Thanks for fixing this @AlokTakshak!

@btmills btmills closed this Jun 10, 2019
@AlokTakshak AlokTakshak deleted the closes#491 branch June 11, 2019 05:41
@AlokTakshak AlokTakshak restored the closes#491 branch June 11, 2019 05:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
triage An ESLint team member will look at this issue soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants