Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revert the CSS changes for now and see how things look with just the blockquote removal in the Markdown source. If we need to add a CSS change later, we can do so. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Would like to have one more set of eyes on this.
@AlokTakshak apologies for not seeing this before, and thanks for the tag @platinumazure. When we do a release of ESLint, the build process regenerates the eslint.org site in this repository from documentation stored in eslint/eslint, which is the authoritative copy. Here’s this file over in the main repository: https://github.com/eslint/eslint/blob/master/docs/developer-guide/working-with-rules.md Can you open a pull request in the eslint/eslint repository with this change and tag me or request a review so I get a notification? That’ll keep your fix from being overwritten by the next release. It looks like the blank lines before Thanks for your patience in getting this fixed! |
@btmills i tagged you in the other PR on |
This was fixed in eslint/eslint#11818, and it's now visible in the v6 prerelease docs! The fix will make its way into the main docs once v6.0.0 is released. Thanks for fixing this @AlokTakshak! |
No description provided.