Fix: don't render links when plugin replaces core rule

eslint · May 8, 2020 · 52021ef · 52021ef
1 parent 384d874
commit 52021ef
Showing 1 changed file with 16 additions and 11 deletions.
diff --git a/docs/rules/index.liquid b/docs/rules/index.liquid
@@ -50,17 +50,22 @@ layout: doc
             <td markdown="1">
               <a href="{{ rule.name }}">{{ rule.name }}</a>
             </td>
-            {% if rule.replacedBy.size > 0 %}
-              <td class="replaced-by" markdown="1">
-                {% for replaced in rule.replacedBy %}
-                <a href="{{ replaced }}">{{ replaced }}</a>
-                {% endfor %}
-              </td>
-            {% else %}
-              <td class="replaced-by" markdown="1">
-                <p class="text-muted">(no replacement)</p>
-              </td>
-            {% endif %}
+            <td class="replaced-by" markdown="1">
+              {% assign hasReplacement = false %}
+              {% if rule.replacedBy.size > 0 %}
+                  {% for replaced in rule.replacedBy %}
+                    {% comment %} Do not link to comments in 3rd party plugins. {% endcomment %}
+                    {% assign ruleNameSegments = replaced | split: "/" %}
+                    {% if ruleNameSegments.size == 1 %}
+                      <a href="{{ replaced }}">{{ replaced }}</a>
+                      {% assign hasReplacement = true %}
+                    {% endif %}
+                  {% endfor %}
+              {% endif %}
+              {% if hasReplacement == false %}
+                  <p class="text-muted">(no replacement)</p>
+              {% endif %}
+            </td>
           </tr>
         {% endfor %}
       </tbody>