lines-between-class-members only supports exceptAfterOverload with 'always' #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eslint-stylistic ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5 tasks
|
Could you add the test case at the end of the list with a comment linking to the issue? Thanks. |
|
@antfu sure, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR with failing test for issue #240
The
exceptAfterOverload: trueoption for the TS version of lines-between-class-members only applies if the first options is'always'. If using the Object version with'enforce', overloads are still flagged as an error.Linked Issues
#240
Additional context