Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prefer-immutable-types): change the options in recommeneded and lite configs #810

Open
wants to merge 1 commit into
base: 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared
Choose a base branch
from
Open

feat(prefer-immutable-types): change the options in recommeneded and lite configs #810

wants to merge 1 commit into from

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Apr 18, 2024 •
edited

No description provided.

This was referenced Apr 18, 2024
Open
Open
Closed
Open
@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Apr 18, 2024 •
edited

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens mentioned this pull request Apr 18, 2024
Open
@RebeccaStevens RebeccaStevens marked this pull request as ready for review April 18, 2024 08:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f62f410 to 414f358 Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 22, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 9437fe3 to a63f57c Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 414f358 to 389d79d Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from a63f57c to 3563ace Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 389d79d to dd561f5 Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 3563ace to 76a233f Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from dd561f5 to 86216cb Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 76a233f to 19b9672 Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 86216cb to 3818253 Compare May 3, 2024 06:36
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 19b9672 to 3e4c47c Compare May 3, 2024 06:36
@RebeccaStevens RebeccaStevens mentioned this pull request May 3, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 3818253 to 311970a Compare May 6, 2024 01:01
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 3e4c47c to 7646b39 Compare May 6, 2024 01:01
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 311970a to 86b0162 Compare May 6, 2024 01:17
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 7646b39 to 265bc68 Compare May 6, 2024 01:17
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 86b0162 to 8dd704a Compare May 6, 2024 04:13
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 265bc68 to 29fab99 Compare May 6, 2024 04:13
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 8dd704a to 79741ab Compare May 6, 2024 04:18
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 29fab99 to a106b81 Compare May 6, 2024 04:18
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 79741ab to 0903137 Compare May 6, 2024 04:31
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from a106b81 to d0bd5dd Compare May 6, 2024 04:31
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0903137 to 2c6e45b Compare May 6, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from d0bd5dd to 10eb938 Compare May 6, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 2c6e45b to a09d559 Compare May 6, 2024 11:06
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 10eb938 to fb2ac2d Compare May 6, 2024 11:06
@RebeccaStevens RebeccaStevens mentioned this pull request May 6, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a09d559 to 0b09d6f Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from fb2ac2d to 26118a1 Compare May 6, 2024 11:30
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0b09d6f to ff3c821 Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 26118a1 to d6524a2 Compare May 6, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from ff3c821 to 08152bb Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from d6524a2 to 55b4941 Compare May 7, 2024 00:19
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 08152bb to b7d0cf8 Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 55b4941 to ff1550f Compare May 9, 2024 23:55
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from b7d0cf8 to da6f22d Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from ff1550f to f5b1ed2 Compare May 12, 2024 06:09
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from da6f22d to e98de95 Compare May 19, 2024 03:27
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from f5b1ed2 to 3fe5b0c Compare May 19, 2024 03:28
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from e98de95 to a20d63e Compare May 25, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 3fe5b0c to fa805b5 Compare May 25, 2024 10:23
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a20d63e to f730ae6 Compare May 25, 2024 11:08
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from fa805b5 to 008c9fe Compare May 25, 2024 11:08
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f730ae6 to 0713a0f Compare May 25, 2024 11:16
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 008c9fe to 699ebc5 Compare May 25, 2024 11:17
@RebeccaStevens RebeccaStevens mentioned this pull request May 25, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0713a0f to 67f5e6e Compare May 25, 2024 12:39
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 699ebc5 to 9962d12 Compare May 25, 2024 12:40
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 67f5e6e to ac98f6b Compare May 25, 2024 13:32
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 9962d12 to 2486537 Compare May 25, 2024 13:32
@RebeccaStevens
feat(prefer-immutable-types): change the options in recommeneded and …
b34253f 
…lite configs

Recommended: Parameters must be deeply readonly when typed with a type defined in a local file.
Types defined in packages in the ts lib must be readonly shallow.

Lite: Parameters must be shallowly readonly when typed with a type defined in a local file.
There is no enforcement on types defined elsewhere.
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from ac98f6b to 525eb6a Compare May 26, 2024 05:11
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_prefer-immutable-types_change_default_options_in_recommeneded_and_lite_configs branch from 2486537 to b34253f Compare May 26, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RebeccaStevens