chore: prettier all files with lint-staged #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjamundx
reviewed
Dec 18, 2021
package.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "bugs": "https://github.com/xjamundx/eslint-plugin-promise/issues", | |||
| "scripts": { | |||
| "format": "prettier --write .", | |||
| "lint": "eslint .", | |||
| "lint": "eslint . && prettier -c .", | |||
There was a problem hiding this comment.
I don't know if I agree with this one change. what do you see as the benefit here? Is this similar to eslint --fix ?
There was a problem hiding this comment.
ESLint only checks the JS files, but prettier is run on everying. The lint-staged will catch stuff if people have made the commit from a setup local environment, but not from the web. This way the full formatting check gets run in CI
Run for all files in lint-staged, and check on CI through `lint`
nschonni
force-pushed
the
prettier-all
branch
from
1716b4f
to
b3059d5
Compare
MichaelDeBoey
requested changes
Sep 29, 2022
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run for all files in lint-staged, and check on CI through
lintWhat is the purpose of this pull request?
What changes did you make? (Give an overview)