chore: put __tests__/.eslintrc.json in root's config's override
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tell me more about why this is better. The old way made sense to me. This also seems fine. Just wondering if there's a big benefit. |
|
Yeah, either way is fine. Using the single file, you get to see all the rules and overrides in a single location when you want to add/remove plug-ins |
nschonni
force-pushed
the
eslint-overrieds
branch
from
44d6182
to
1241e0c
Compare
MichaelDeBoey
changed the title
__tests__/.eslintrc.json in root's config's override
MichaelDeBoey
requested changes
Sep 29, 2022
Comment on lines
+31
to
+35
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:jest/recommended", | ||
| "plugin:prettier/recommended" | ||
| ], |
There was a problem hiding this comment.
We should keep this as __tests__/.eslintrc.json was
Suggested change
| "extends": [ | |
| "eslint:recommended", | |
| "plugin:jest/recommended", | |
| "plugin:prettier/recommended" | |
| ], | |
| "extends": ["plugin:jest/recommended"], |
There was a problem hiding this comment.
AFAIK, overrides wipes out the whole property, that's why the full set of extends is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
What changes did you make? (Give an overview)
Merged up the nested ESLint config to an override in the root one