Drop Node < 10 #197
Closed
Drop Node < 10 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
approved these changes
Jul 9, 2020
|
Would this require a semver major change? Or will it not actually break, just more recommend? |
…g tested in Travis BREAKING CHANGE: Requires Node 10.
|
Closed by #190 . https://github.com/xjamundx/eslint-plugin-promise/pull/190/files . (And apologies hadn't seen comment; the reason these break is that for users with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update
enginesto reflect (maintained) versions of Node being tested in TravisBREAKING CHANGE:
Requires Node 10.
What is the purpose of this pull request?
Update
enginesinpackage.json.What changes did you make? (Give an overview)
Given the recent changes to test only the currently maintained versions of Node (10, 12, 14), I wanted to offer this PR if you wanted to enforce that requirement, given that we are not verifying whether changes now are breaking earlier Node versions.