param-names fixer breaks code functionality

[adrianmcli]

Description

The fixer for the param-names rule breaks code functionality.

The fixer renames arguments in a Promise constructor function, but does not propagate the name change to the calling code.

Steps to Reproduce

Run the ESLint fixer on the following code:

new Promise((yes, no) => { yes("hello") })'

Expected behavior:

new Promise((resolve, reject) => { resolve("hello") })'

Actual behavior:

new Promise((resolve, reject) => { yes("hello") })'

Additional Information

Rather than trying to change people's code, I think it's better to remove the fixer rather than change variable names everywhere.

[adrianmcli]

Can submit a PR for this if we can agree that it's better to remove the fixer.

[macklinu]

Removing the fixer sounds like a good idea. Thanks for pointing this out - PR welcome for that!

[adrianmcli]

Sounds good! Working on it now.

[adrianmcli]

@macklinu PR submitted: #146