Fixer for eslint-plugin-promise breaks code functionality

[adrianmcli]

What version of standard? v12.0.1

This problem stems from the eslint-plugin-promise project, and specifically the param-names rule.

Reproduction

Run the ESLint fixer on the following code:

new Promise((yes, no) => { yes("hello") })'

Expected behavior:

new Promise((resolve, reject) => { resolve("hello") })'

Actual behavior:

new Promise((resolve, reject) => { yes("hello") })'

Additional Information

Rather than trying to change people's code, I think it's better to remove the fixer rather than change variable names everywhere. I have submitted an issue to the eslint-plugin-promise repo: eslint-community/eslint-plugin-promise#145

If and when there is a resolution to that issue, we should take steps to update accordingly.

[adrianmcli]

Update:

• A maintainer has agreed that we should remove the fixer:
  • param-names fixer breaks code functionality eslint-community/eslint-plugin-promise#145 (comment)
• PR has been submitted and merged:
  • Fix/remove param names fixer eslint-community/eslint-plugin-promise#146

Now just waiting on v4.0.1 patch release as per: eslint-community/eslint-plugin-promise#146 (review)

[adrianmcli]

v4.0.1 has been released and published, and this issue should now be fixed.

Github release link: https://github.com/xjamundx/eslint-plugin-promise/releases/tag/v4.0.1
NPM link: https://www.npmjs.com/package/eslint-plugin-promise

[feross]

Thanks @adrianmcli